From: Austin Clements Date: Fri, 31 May 2013 23:33:15 +0000 (+2000) Subject: Re: [PATCH v3 0/5] emacs: show: lazy handling of hidden parts X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=7c36e9fb3f24d3774aa5f5e4f2553c0958c38b34;p=notmuch-archives.git Re: [PATCH v3 0/5] emacs: show: lazy handling of hidden parts --- diff --git a/49/78014750607c3ad494a8f5de40ffd6f1c46864 b/49/78014750607c3ad494a8f5de40ffd6f1c46864 new file mode 100644 index 000000000..c7b4772e4 --- /dev/null +++ b/49/78014750607c3ad494a8f5de40ffd6f1c46864 @@ -0,0 +1,132 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id B851E431FDB + for ; Fri, 31 May 2013 16:33:25 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id pc9JJClSSXpt for ; + Fri, 31 May 2013 16:33:18 -0700 (PDT) +Received: from dmz-mailsec-scanner-4.mit.edu (dmz-mailsec-scanner-4.mit.edu + [18.9.25.15]) + by olra.theworths.org (Postfix) with ESMTP id BF8F3431FBD + for ; Fri, 31 May 2013 16:33:18 -0700 (PDT) +X-AuditID: 1209190f-b7f256d000005616-0d-51a9333e05fd +Received: from mailhub-auth-4.mit.edu ( [18.7.62.39]) + by dmz-mailsec-scanner-4.mit.edu (Symantec Messaging Gateway) with SMTP + id 9A.0F.22038.E3339A15; Fri, 31 May 2013 19:33:18 -0400 (EDT) +Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) + by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id r4VNXHKT009843; + Fri, 31 May 2013 19:33:17 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r4VNXF9U001980 + (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); + Fri, 31 May 2013 19:33:16 -0400 +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80) + (envelope-from ) + id 1UiYot-0005GY-9D; Fri, 31 May 2013 19:33:15 -0400 +From: Austin Clements +To: Mark Walters , notmuch@notmuchmail.org, + Adam Wolfe Gordon +Subject: Re: [PATCH v3 0/5] emacs: show: lazy handling of hidden parts +In-Reply-To: <1370024806-6616-1-git-send-email-markwalters1009@gmail.com> +References: <1370024806-6616-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.15.2+83~g8bee3c4 (http://notmuchmail.org) Emacs/23.4.1 + (i486-pc-linux-gnu) +Date: Fri, 31 May 2013 19:33:15 -0400 +Message-ID: <87wqqe2090.fsf@awakening.csail.mit.edu> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFvrOIsWRmVeSWpSXmKPExsUixG6nrmtnvDLQYMEjfosje2axW6yey2Nx + /eZMZgdmj52z7rJ7PFt1i9mj6cdi1gDmKC6blNSczLLUIn27BK6MlnU9TAVTBCt2NzWwNDA+ + 4u1i5OSQEDCRuNX8jxXCFpO4cG89WxcjF4eQwD5Gie9du5khnI2MEu9/bGWFcE4zSVy/epsJ + wlnCKPHkw1QWkH42AQ2JbfuXM4LYIgJlElumz2ICsZkFdCRO7N4GFhcWcJP4fKeNDcTmFPCU + OHlqI5gtJOAhcXn/drA7RAUSJFbePQFWzyKgKnHyejeYzQt06/0zDawQtqDEyZlPWCDma0nc + +PeSaQKj4CwkqVlIUgsYmVYxyqbkVunmJmbmFKcm6xYnJ+blpRbpmujlZpbopaaUbmIEhS+n + JP8Oxm8HlQ4xCnAwKvHwdqxaESjEmlhWXJl7iFGSg0lJlLdefWWgEF9SfkplRmJxRnxRaU5q + 8SFGCQ5mJRHe/DlA5bwpiZVVqUX5MClpDhYlcd6rKTf9hQTSE0tSs1NTC1KLYLIyHBxKErxp + RkBDBYtS01Mr0jJzShDSTBycIMN5gIZ3gtTwFhck5hZnpkPkTzEqSonzuoAkBEASGaV5cL2w + 9PKKURzoFWFeH5AqHmBqgut+BTSYCWjwE+vlIINLEhFSUg2Mdq+LZkrf3/og/BNn/dUyRwWH + pO2fPIL3e7zPUP+kErpmx9dHDozq1v8cV0Y9+mN1c7J7t27JJ+YA/6u7mXpVohaf+Bt2amWa + y/Xr997//HPzsDeTjSlbVVPkhdZ4T42UwsV8uhHyZ5qM+1mUVq1IbuWJM+kyOeh6ObXsVuvB + xGNpIWaz1JcrsRRnJBpqMRcVJwIAX5IsGgoDAAA= +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 31 May 2013 23:33:25 -0000 + +LGTM other than the tiny things I mentioned. As Mark says, there are a +lot of paths through this code (though he did a good job of minimizing +them), so it'll need some testing. Of course, what better place to test +than git master? + +As a heads up, I think this will have a trivial conflict with +id:"1369876428-13537-4-git-send-email-amdragon@mit.edu", which is +currently in the ready queue. + +On Fri, 31 May 2013, Mark Walters wrote: +> This is a substantially reworked version of +> id:1369555061-21361-1-git-send-email-markwalters1009@gmail.com +> attempting to answer the (very constructive) criticism of Austin. +> +> The changes are: move the insert-part-header call from the +> insert-part-text/plain function to insert-bodypart in line with all +> the other part insertion functions. +> +> The other change in patch 2 is that we no longer need to pass +> declared-type down to the part insertion functions so we remove this +> argument. +> +> The actual invisibility code has been substantially reworked. There +> were two main aims: to remove the insertion of dummy text and to make +> sure that toggling a lazy-part which cannot be rendered automatically +> calls the default action for such a part (e.g. saving or viewing). +> +> I have split this code into 3 pieces: two pieces of simple code +> movement as preparation and then the new code to do the actual +> lazy part handling. +> +> All tests pass and everything I can think of to try works (viewing +> pdf, lazy rendered html, lazy rendered pdf, toggling all types, +> repeated toggling) but there are a lot of cases so testing is +> especially helpful. +> +> Best wishes +> +> Mark +> +> +> +> +> +> Mark Walters (5): +> emacs: show: fake wash parts are handled at insert-bodypart level +> emacs: show: move the insertion of the header button to the top level +> emacs: show: pass button to create-overlays +> emacs: show: modify the way hidden state is recorded. +> emacs: show: implement lazy hidden part handling +> +> emacs/notmuch-show.el | 183 +++++++++++++++++++++++++++++-------------------- +> 1 file changed, 107 insertions(+), 76 deletions(-) +> +> -- +> 1.7.10.4