From: Mike Hommey Date: Sat, 14 Jun 2008 10:02:22 +0000 (+0200) Subject: Don't allocate too much memory in quote_ref_url X-Git-Tag: v1.5.6-rc3~5 X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=7c1a9e7901a0e75eab8c7fb34d17c09652d47f7f;p=git.git Don't allocate too much memory in quote_ref_url In c13b263, http_fetch_ref got "refs/" included in the ref passed to it, which, incidentally, makes the allocation in quote_ref_url too big, now. Signed-off-by: Junio C Hamano --- diff --git a/http.c b/http.c index 2a21ccbb7..105dc9384 100644 --- a/http.c +++ b/http.c @@ -583,7 +583,7 @@ static char *quote_ref_url(const char *base, const char *ref) int len, baselen, ch; baselen = strlen(base); - len = baselen + 7; /* "/refs/" + NUL */ + len = baselen + 2; /* '/' after base and terminating NUL */ for (cp = ref; (ch = *cp) != 0; cp++, len++) if (needs_quote(ch)) len += 2; /* extra two hex plus replacement % */