From: Tomi Ollila Date: Tue, 27 Oct 2015 22:55:33 +0000 (+0200) Subject: Re: elisp + company completion patches, v7 X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=7c0286b790f7eaeac40c13a7a4901dee367c1b87;p=notmuch-archives.git Re: elisp + company completion patches, v7 --- diff --git a/93/da8325251e1e9998e656f24bf20a59658ea166 b/93/da8325251e1e9998e656f24bf20a59658ea166 new file mode 100644 index 000000000..a9bec1af7 --- /dev/null +++ b/93/da8325251e1e9998e656f24bf20a59658ea166 @@ -0,0 +1,102 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id E47626DE14D6 + for ; Tue, 27 Oct 2015 15:55:34 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 0.746 +X-Spam-Level: +X-Spam-Status: No, score=0.746 tagged_above=-999 required=5 tests=[AWL=0.094, + SPF_NEUTRAL=0.652] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id owF80TKUMsci for ; + Tue, 27 Oct 2015 15:55:32 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by arlo.cworth.org (Postfix) with ESMTP id 095656DE133A + for ; Tue, 27 Oct 2015 15:55:31 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 67127100046; + Wed, 28 Oct 2015 00:55:33 +0200 (EET) +From: Tomi Ollila +To: Carl Worth , David Bremner , + notmuch@notmuchmail.org +Subject: Re: elisp + company completion patches, v7 +In-Reply-To: <871tche9vr.fsf@wondoo.home.cworth.org> +References: <1445786638-13763-1-git-send-email-david@tethera.net> + <871tche9vr.fsf@wondoo.home.cworth.org> +User-Agent: Notmuch/0.21~rc3+7~g28030b0 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 27 Oct 2015 22:55:35 -0000 + +On Mon, Oct 26 2015, Carl Worth wrote: + +> On Sun, Oct 25 2015, Tomi Ollila wrote: +>> I, if this does not sound nitpicking, would amend those 'This patch' and +>> 'With this patch' texts in commit messages away by some rewording -- those +>> pose as a bad example for someone reading the code -- and diminish the +>> effect when I complain that again in future patched ;) +> +> What's the motivation here? +> +> It's often the case that a good commit message needs to describe the way +> things were working prior to a commit, (describing the bug or missing +> feature or what have you), and also needs to describe the change that is +> affected by the commit itself. +> +> So I actually like seeing commit messages that say things like: +> +> Prior to this commit... (some bug existed...) +> +> In this commit... (some code is reworked to fix the bug...) +> +> But maybe I've missed the point of your message. +> +> +> -Carl + +Probably the missing point is the fine distinction between +'this patch' and 'this commit' + +While we do sets of changes and then that leads to commit series the final +step of running 'git format-patch' somehow leads people writing commit +message to add words 'this patch' to the message... +... or (what just come into my mind) they just think these changes as +patches (is that linux-kernel influence ?) + +To me the commit history does not look like series of patches (but series +of commits or changes -- and changes are usually shown as "diffs") -- +patching gives a connotation of fixing something (with glue or gum ;) + +That is how I see it. That doesn't mean I am right there (and in this mailing +list I've been wrong in statistically significant amount (*) of times). + +Un{less,til} decided otherwise I'll continue with delicate efforts to +keep this style issue in the minds of developers; despite (**) informing +me that will be doomed... + +Tomi + +(*) https://en.wikipedia.org/wiki/Statistical_significance +(**) https://en.wikipedia.org/wiki/Wiio%27s_laws