From: Zac Medico <zmedico@gentoo.org>
Date: Mon, 5 Feb 2007 20:45:23 +0000 (-0000)
Subject: For bug #165382, don't raise a ValueError in cpv_expand() if there are only two match... 
X-Git-Tag: v2.1.2-r9~15
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=7be94181e5d5d7e88f0e50912512203d36a8aaf5;p=portage.git

For bug #165382, don't raise a ValueError in cpv_expand() if there are only two matches and one of them is a virtual.  Prefer the non-virtual instead. (trunk r5889:5891)

svn path=/main/branches/2.1.2/; revision=5896
---

diff --git a/pym/portage.py b/pym/portage.py
index d9b283e94..5c4389c9c 100644
--- a/pym/portage.py
+++ b/pym/portage.py
@@ -4434,8 +4434,18 @@ def cpv_expand(mycpv, mydb=None, use_cache=1, settings=None):
 			for x in settings.categories:
 				if mydb.cp_list(x+"/"+myp,use_cache=use_cache):
 					matches.append(x+"/"+myp)
-		if (len(matches)>1):
-			raise ValueError, matches
+		if len(matches) > 1:
+			if len(matches) == 2:
+				for x in matches:
+					if not x.startswith("virtual/"):
+						# Assume that the non-virtual is desired.  This helps
+						# avoid the ValueError for invalid deps that come from
+						# installed packages (during reverse blocker detection,
+						# for example).
+						mykey = x
+						break
+			if mykey is None:
+				raise ValueError, matches
 		elif matches:
 			mykey=matches[0]