From: David Bremner Date: Tue, 24 Mar 2015 13:19:43 +0000 (+2000) Subject: [Patch v5 5/8] lib: add a log function with output to a string in notmuch_database_t X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=7badd33c68ad29b81c304d85edf6baf6cc1a55d2;p=notmuch-archives.git [Patch v5 5/8] lib: add a log function with output to a string in notmuch_database_t --- diff --git a/45/d4d4c9af76fbf27e2df3fedf038f3617a5a634 b/45/d4d4c9af76fbf27e2df3fedf038f3617a5a634 new file mode 100644 index 000000000..165e6dc3c --- /dev/null +++ b/45/d4d4c9af76fbf27e2df3fedf038f3617a5a634 @@ -0,0 +1,156 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 54FB8429E30 + for ; Tue, 24 Mar 2015 06:21:06 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 2.438 +X-Spam-Level: ** +X-Spam-Status: No, score=2.438 tagged_above=-999 required=5 + tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id Dj79XNb3h2fb for ; + Tue, 24 Mar 2015 06:21:02 -0700 (PDT) +Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net + [87.98.215.224]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 87867429E2E + for ; Tue, 24 Mar 2015 06:21:02 -0700 (PDT) +Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim + 4.80) (envelope-from ) + id 1YaOkg-0000pN-B7; Tue, 24 Mar 2015 13:20:14 +0000 +Received: (nullmailer pid 32636 invoked by uid 1000); Tue, 24 Mar 2015 + 13:19:47 -0000 +From: David Bremner +To: David Bremner , notmuch@notmuchmail.org +Subject: [Patch v5 5/8] lib: add a log function with output to a string in + notmuch_database_t +Date: Tue, 24 Mar 2015 09:19:43 -0400 +Message-Id: <1427203186-32194-5-git-send-email-david@tethera.net> +X-Mailer: git-send-email 2.1.4 +In-Reply-To: <1427203186-32194-1-git-send-email-david@tethera.net> +References: <1426352554-4383-10-git-send-email-david@tethera.net> + <1427203186-32194-1-git-send-email-david@tethera.net> +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 24 Mar 2015 13:21:06 -0000 + +In principle in the future this could do something fancier than sprintf. +--- + lib/database-private.h | 4 ++++ + lib/database.cc | 24 ++++++++++++++++++++++++ + lib/notmuch-private.h | 4 ++++ + lib/notmuch.h | 7 +++++++ + 4 files changed, 39 insertions(+) + +diff --git a/lib/database-private.h b/lib/database-private.h +index 6d6fa2c..24243db 100644 +--- a/lib/database-private.h ++++ b/lib/database-private.h +@@ -154,6 +154,10 @@ struct _notmuch_database { + unsigned int last_doc_id; + uint64_t last_thread_id; + ++ /* error reporting; this value persists only until the ++ * next library call. May be NULL */ ++ char *status_string; ++ + Xapian::QueryParser *query_parser; + Xapian::TermGenerator *term_gen; + Xapian::ValueRangeProcessor *value_range_processor; +diff --git a/lib/database.cc b/lib/database.cc +index 36849d7..673561b 100644 +--- a/lib/database.cc ++++ b/lib/database.cc +@@ -348,6 +348,23 @@ notmuch_status_to_string (notmuch_status_t status) + } + } + ++void ++_notmuch_database_log (notmuch_database_t *notmuch, ++ const char *format, ++ ...) ++{ ++ va_list va_args; ++ ++ va_start (va_args, format); ++ ++ if (notmuch->status_string) ++ talloc_free (notmuch->status_string); ++ ++ notmuch->status_string = talloc_vasprintf (notmuch, format, va_args); ++ ++ va_end (va_args); ++} ++ + static void + find_doc_ids_for_term (notmuch_database_t *notmuch, + const char *term, +@@ -845,6 +862,7 @@ notmuch_database_open_verbose (const char *path, + + notmuch = talloc_zero (NULL, notmuch_database_t); + notmuch->exception_reported = FALSE; ++ notmuch->status_string = NULL; + notmuch->path = talloc_strdup (notmuch, path); + + if (notmuch->path[strlen (notmuch->path) - 1] == '/') +@@ -2530,3 +2548,9 @@ notmuch_database_get_all_tags (notmuch_database_t *db) + return NULL; + } + } ++ ++const char * ++notmuch_database_status_string (notmuch_database_t *notmuch) ++{ ++ return notmuch->status_string; ++} +diff --git a/lib/notmuch-private.h b/lib/notmuch-private.h +index 8a1f2fa..7cb6fd4 100644 +--- a/lib/notmuch-private.h ++++ b/lib/notmuch-private.h +@@ -190,6 +190,10 @@ _notmuch_message_id_compressed (void *ctx, const char *message_id); + notmuch_status_t + _notmuch_database_ensure_writable (notmuch_database_t *notmuch); + ++void ++_notmuch_database_log (notmuch_database_t *notmuch, ++ const char *format, ...); ++ + const char * + _notmuch_database_relative_path (notmuch_database_t *notmuch, + const char *path); +diff --git a/lib/notmuch.h b/lib/notmuch.h +index c671d82..20c4e01 100644 +--- a/lib/notmuch.h ++++ b/lib/notmuch.h +@@ -302,6 +302,13 @@ notmuch_database_open_verbose (const char *path, + char **error_message); + + /** ++ * Retrieve last status string for given database. ++ * ++ */ ++const char * ++notmuch_database_status_string (notmuch_database_t *notmuch); ++ ++/** + * Commit changes and close the given notmuch database. + * + * After notmuch_database_close has been called, calls to other +-- +2.1.4 +