From: Junio C Hamano <junkio@cox.net>
Date: Fri, 6 Oct 2006 06:40:15 +0000 (-0700)
Subject: git-send-email: real name with period need to be dq-quoted on From: line
X-Git-Tag: v1.4.4-rc1~85^2~1
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=7a2a0d214169a5d6f22fc62c4ae6a7ca5b27fb3e;p=git.git

git-send-email: real name with period need to be dq-quoted on From: line

An author name like 'A. U. Thor <a.u.thor@example.com>" is not a
valid RFC 2822 address; when placing it on From: line, we would
need to quote it, like this:

Signed-off-by: "Junio C. Hamano" <junkio@cox.net>
---

diff --git a/git-send-email.perl b/git-send-email.perl
index 2fd5e8793..21b3686b2 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -409,6 +409,11 @@ sub send_message
 	    $gitversion = Git::version();
 	}
 
+	my ($author_name) = ($from =~ /^(.*?)\s+</);
+	if ($author_name =~ /\./ && $author_name !~ /^".*"$/) {
+		my ($name, $addr) = ($from =~ /^(.*?)(\s+<.*)/);
+		$from = "\"$name\"$addr";
+	}
 	my $header = "From: $from
 To: $to
 Cc: $cc