From: Gaute Hope Date: Sat, 11 Apr 2015 09:12:11 +0000 (+0000) Subject: Re: [PATCH] Re: Add /renew/ tag to moved/renamed/reflagged messages X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=78c76a4009f4c55480f56f4ab6ff559d93c375d8;p=notmuch-archives.git Re: [PATCH] Re: Add /renew/ tag to moved/renamed/reflagged messages --- diff --git a/f2/42e7ac1174cdb50ac3be5587ac8f338b4548f0 b/f2/42e7ac1174cdb50ac3be5587ac8f338b4548f0 new file mode 100644 index 000000000..8bd5e4805 --- /dev/null +++ b/f2/42e7ac1174cdb50ac3be5587ac8f338b4548f0 @@ -0,0 +1,113 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 7DB6E6DE1704 + for ; Sat, 11 Apr 2015 02:12:21 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 0.589 +X-Spam-Level: +X-Spam-Status: No, score=0.589 tagged_above=-999 required=5 tests=[AWL=1.290, + RCVD_IN_DNSWL_LOW=-0.7, + RCVD_IN_MSPIKE_H2=-0.001] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 8jK1tAv4lGkl for ; + Sat, 11 Apr 2015 02:12:19 -0700 (PDT) +Received: from mail-lb0-f172.google.com (mail-lb0-f172.google.com + [209.85.217.172]) + by arlo.cworth.org (Postfix) with ESMTPS id E094B6DE163F + for ; Sat, 11 Apr 2015 02:12:18 -0700 (PDT) +Received: by lbbqq2 with SMTP id qq2so28770961lbb.3 + for ; Sat, 11 Apr 2015 02:12:15 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:date:from:subject:to:references:in-reply-to + :user-agent:message-id:mime-version:content-type + :content-transfer-encoding; + bh=/w8btXuz3opm6ZmAo3d7KvaucOUTCvO2AD95gaBqQvE=; + b=MDi1OaLaNSqTRFHfCVdp8x/D/xT1wZmyWT0Oo3Nv6TZaG0ppXubAzEJ20KEt2G20hw + 5eQEP1CkXfD+H79dvePpA8EJBaUqkUcsU0gNprsXesJbYqNbxgM2tvINXBfMlqtmIkBr + INgf5o5ixk/VDkvt3ydh/fDKam1wf/i0q1lZUVebi/PZsQVSOv+LeiAOkTfg53ESHv5/ + 04DproszZXPtomuX3jQ+hLjrTQS7R0sthD1l/T0Z0sH7MBq+GsXJ1Shtk9judgEJjTBT + Ht6iEOjIGui56qhkPgj3Jegzn0KEzlsM8XYOsnD7ZzbKTDfTxDnHgf79KxW+FHSjTOVI + Yg9A== +X-Gm-Message-State: + ALoCoQnTfdRffpQNiCl+asfVrco9zUw1/sNdPoURY4uovdT+JuoxtF29s4WiqouGi+OzJYYN8SO8 +X-Received: by 10.152.205.106 with SMTP id lf10mr4830829lac.89.1428743533924; + Sat, 11 Apr 2015 02:12:13 -0700 (PDT) +Received: from localhost (c7579BF51.dhcp.as2116.net. [81.191.121.117]) + by mx.google.com with ESMTPSA id rp10sm290121lbb.8.2015.04.11.02.12.11 + (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Sat, 11 Apr 2015 02:12:12 -0700 (PDT) +Date: Sat, 11 Apr 2015 09:12:11 +0000 +From: Gaute Hope +Subject: Re: [PATCH] Re: Add /renew/ tag to moved/renamed/reflagged messages +To: David Bremner , Baptiste , + notmuch@notmuchmail.org +References: <87ioegq5ca.fsf@vm_arch_64.bat.fr.eu.org> + <87fv9kq1fu.fsf@vm_arch_64.bat.fr.eu.org> + <87pp7bwn93.fsf@maritornes.cs.unb.ca> +In-Reply-To: <87pp7bwn93.fsf@maritornes.cs.unb.ca> +User-Agent: astroid/vv0.2-23-gd0081277 (https://github.com/gauteh/astroid) +Message-Id: <1428743351-astroid-1-syzinp7fwu-1358@strange> +MIME-Version: 1.0 +Content-Type: text/plain; charset=utf-8; format=flowed +Content-Transfer-Encoding: quoted-printable +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 11 Apr 2015 09:12:21 -0000 + +Excerpts from David Bremner's message of April 11, 2015 1:56: +> Baptiste writes: +>=20 +>> Hi,=20 +>> +>>> What about another automatic tag to re-add to an existing mail when =3D= +notmuch new=3D detect a moved, renamed or reflagged message=C2=A0... +>> +>> the following code sample seems to actually do the job=C2=A0=E2=80=A6 +>> +>=20 +> Sorry I still haven't had a chance to review your patch in detail. A few +> things I did wonder about +>=20 +> - There is a patch series in progress to add a "last modified time" to +> all messages [1]. It seems like this should also work for your case +> since renaming counts as modification in this context. It might not be +> quite as easy/efficient for your use case as your proposal, but it +> seems like it should work. +>=20 +> - What about messages added by notmuch-insert? I guess you are maybe not +> using it, but it seems odd to only support changes detected in +> notmuch-new. +>=20 +> - This might be because I haven't worked through the details, but it +> isn't obvious to me how your patch behaves with messages with multiple +> files on disk. +>=20 +>=20 +>=20 +> [1]: id:1428274754-1698-1-git-send-email-david@tethera.net + +I think I sent in something similar [2] before the lastmod stuff, there +are some issues with reliably detecting all changes. Especially, changes +that do not result in a rename. It would be made obsolete by the lastmod +series though. + +- gaute + +[2]: id:1396800683-9164-1-git-send-email-eg@gaute.vetsj.com=20 + +=