From: David Bremner <david@tethera.net>
Date: Sun, 2 Aug 2015 10:33:58 +0000 (+0200)
Subject: Re: [PATCH] custom search prefix
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=789c3b25dbd9298b481d9b136e6cf7f7e836ee1d;p=notmuch-archives.git

Re: [PATCH] custom search prefix
---

diff --git a/bf/6a310a78d3d7f8cd478edff13dd4ba19016240 b/bf/6a310a78d3d7f8cd478edff13dd4ba19016240
new file mode 100644
index 000000000..f40b28bfc
--- /dev/null
+++ b/bf/6a310a78d3d7f8cd478edff13dd4ba19016240
@@ -0,0 +1,71 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id EE16B6DE17A6
+ for <notmuch@notmuchmail.org>; Sun,  2 Aug 2015 03:35:02 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: 0.144
+X-Spam-Level: 
+X-Spam-Status: No, score=0.144 tagged_above=-999 required=5 tests=[AWL=0.144]
+ autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id Xpzq4T2BmlEl for <notmuch@notmuchmail.org>;
+ Sun,  2 Aug 2015 03:35:01 -0700 (PDT)
+Received: from gitolite.debian.net (gitolite.debian.net [87.98.215.224])
+ by arlo.cworth.org (Postfix) with ESMTPS id 31FD26DE1761
+ for <notmuch@notmuchmail.org>; Sun,  2 Aug 2015 03:35:01 -0700 (PDT)
+Received: from remotemail by gitolite.debian.net with local (Exim 4.80)
+ (envelope-from <david@tethera.net>)
+ id 1ZLqar-0000qk-Qv; Sun, 02 Aug 2015 10:34:13 +0000
+Received: (nullmailer pid 31965 invoked by uid 1000); Sun, 02 Aug 2015
+ 10:33:58 -0000
+From: David Bremner <david@tethera.net>
+To: sfischme@uwaterloo.ca, notmuch <notmuch@notmuchmail.org>
+Subject: Re: [PATCH] custom search prefix
+In-Reply-To: <87siceqcyl.fsf@uwaterloo.ca>
+References: <87siceqcyl.fsf@uwaterloo.ca>
+User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.1
+ (x86_64-pc-linux-gnu)
+Date: Sun, 02 Aug 2015 12:33:58 +0200
+Message-ID: <87k2te3rop.fsf@maritornes.cs.unb.ca>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.18
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sun, 02 Aug 2015 10:35:03 -0000
+
+
+Hi Sebastian;
+
+Sorry this sat so long in the queue.
+
+I agree it doesn't cost much to add it, but offhand I'm not sure what
+the use case is. It would be be good to (briefly) mention this in the
+commit message and also expand the docstring for the variable a bit,
+since this is currently our only documentation.
+
+> +(defcustom notmuch-query-prefix nil
+> +  "Add a prefix to the standard query."
+> +  :type 'string
+> +  :group 'notmuch-search)
+> +
+
+In addition to general comments about, I'd say that "standard query" is
+a bit ambigious for me. It sounds like it would be added e.g. to
+saved-searches.  Maybe "default" search, with some discussion of where
+it is used (so people don't have to read the source to figure it out).
+
+d