From: Sebastian Lipp Date: Sun, 6 Jul 2014 20:37:40 +0000 (+0200) Subject: Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=782bd1e0c0ea1b6dfad8c9403e8c471e6b25e2c6;p=notmuch-archives.git Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. --- diff --git a/28/34638c91aa839f8e782470dad52f6c6b52aa24 b/28/34638c91aa839f8e782470dad52f6c6b52aa24 new file mode 100644 index 000000000..46fe4efce --- /dev/null +++ b/28/34638c91aa839f8e782470dad52f6c6b52aa24 @@ -0,0 +1,111 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 0EFF0431FBD + for ; Sun, 6 Jul 2014 13:38:28 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.099 +X-Spam-Level: +X-Spam-Status: No, score=-0.099 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + RCVD_IN_DNSWL_NONE=-0.0001, UNPARSEABLE_RELAY=0.001] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id iYPYKqSpCcnz for ; + Sun, 6 Jul 2014 13:38:20 -0700 (PDT) +Received: from mx1.riseup.net (mx1.riseup.net [198.252.153.129]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 17D83431FAF + for ; Sun, 6 Jul 2014 13:38:20 -0700 (PDT) +Received: from fruiteater.riseup.net (fruiteater-pn.riseup.net [10.0.1.74]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (Client CN "*.riseup.net", + Issuer "Gandi Standard SSL CA" (not verified)) + by mx1.riseup.net (Postfix) with ESMTPS id 375CA51BBF; + Sun, 6 Jul 2014 13:38:18 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=riseup.net; s=squak; + t=1404679098; bh=iplnKch84YHXNLRGW+tCPipGUbWq/PDvi5jxHeGjRlw=; + h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: + MIME-Version:Content-Type; + b=VlQ2JE00rgUxPujW0VFFta1U8cXYA+0FL4NTsd6YZjL+LFGiB9qkjsb2Nv65vtOi/ + ljsS3pnisNrnFDS5cez3c7PsbgkC4/BQLwLnTBc7EbqMyFVcR8d4teflz3OReqL13p + EK16Di1+w5CKuL0lp9Wl9ktqeDgHBCvPaCa3lHzk= +Received: from [127.0.0.1] (localhost [127.0.0.1]) + (Authenticated sender: bacuh@fruiteater.riseup.net) + with ESMTPSA id 5B2F28F9 +From: Sebastian Lipp +To: Karl Fogel +Subject: Re: [PATCH] emacs: add missing paren to fix defun in + notmuch-address.el. +In-Reply-To: <87oax6vt4u.fsf@ktab.red-bean.com> +References: <87wqsfik5l.fsf@floss.red-bean.com> + <87mwtah2hd.fsf@zancas.localnet> + <877gkeau42.fsf@floss.red-bean.com> + <8738v1jtzc.fsf@nikula.org> + <87k3odgutd.fsf@zancas.localnet> <87ip3wbj7g.fsf@mcs.anl.gov> + + <87vc7vgbym.fsf@zancas.localnet> + + <87pphmc604.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me> + <87oax6vt4u.fsf@ktab.red-bean.com> +User-Agent: Notmuch/0.18.1 (http://notmuchmail.org) Emacs/24.3.1 + (i686-pc-linux-gnu) +Date: Sun, 06 Jul 2014 22:37:40 +0200 +Message-ID: + <87bnt2dy0b.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me> +MIME-Version: 1.0 +Content-Type: text/plain +X-Virus-Scanned: clamav-milter 0.98.1 at mx1 +X-Virus-Status: Clean +Cc: Tomi Ollila , notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 06 Jul 2014 20:38:28 -0000 + +Karl Fogel writes: +> Sebastian Lipp writes: +>>diff --git a/emacs/notmuch-address.el b/emacs/notmuch-address.el +>>index fa65cd5..ee7b169 100644 +>>--- a/emacs/notmuch-address.el +>>+++ b/emacs/notmuch-address.el +>>@@ -113,6 +113,59 @@ to know how address selection is made by default." +>> (when (notmuch-address-locate-command notmuch-address-command) +>> (notmuch-address-message-insinuate)) +>> +>>+;; functions to add sender / recipients to BBDB +>>+ +>>+(defvar bbdb-get-addresses-headers) +> +> I think it's good to include an initial value (even an invalid +> placeholder one, if the real initialization has not happened yet), and a +> doc string. C-h f defvar RET will say more about how to do that. + +I hope I got that right now. (I've got no real clue of Lisp yet because +I just recently switched to emacs partly because of notmuch. :) + +How about + + (defvar bbdb-get-addresses-headers nil + "List of Addresses to import into bbdb") + +? + +> (By the way, this isn't a user-customizeable variable, right? If it +> were, then `defcustom' would be better than `defvar'.) + +As far as I understand it: It's not. +