From: David Bremner Date: Tue, 28 Oct 2014 18:15:50 +0000 (+0100) Subject: Re: [PATCH] test: fix test_require_external_prereq gdb in insert test X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=77a60588fef2f68bf50ee171fcf2969b0610a09e;p=notmuch-archives.git Re: [PATCH] test: fix test_require_external_prereq gdb in insert test --- diff --git a/43/a3f19846fcd5969689e1046f44d25754b10b50 b/43/a3f19846fcd5969689e1046f44d25754b10b50 new file mode 100644 index 000000000..75cd4f9df --- /dev/null +++ b/43/a3f19846fcd5969689e1046f44d25754b10b50 @@ -0,0 +1,69 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 18F6E431FAE + for ; Tue, 28 Oct 2014 11:16:05 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 9PUTMgNXjQIn for ; + Tue, 28 Oct 2014 11:15:57 -0700 (PDT) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id BD476431FBC + for ; Tue, 28 Oct 2014 11:15:57 -0700 (PDT) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1XjBJD-0002t7-Cw; Tue, 28 Oct 2014 15:15:55 -0300 +Received: (nullmailer pid 30371 invoked by uid 1000); Tue, 28 Oct 2014 + 18:15:50 -0000 +From: David Bremner +To: Jani Nikula , notmuch@notmuchmail.org +Subject: Re: [PATCH] test: fix test_require_external_prereq gdb in insert test +In-Reply-To: <1414518754-16344-1-git-send-email-jani@nikula.org> +References: <1414518754-16344-1-git-send-email-jani@nikula.org> +User-Agent: Notmuch/0.18.1+131~gdd8373f (http://notmuchmail.org) Emacs/24.4.1 + (x86_64-pc-linux-gnu) +Date: Tue, 28 Oct 2014 19:15:50 +0100 +Message-ID: <87a94g2h7t.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 28 Oct 2014 18:16:05 -0000 + +Jani Nikula writes: + +> You need to actually check the return value. Limit the missing deps +> part to subtests requiring gdb. + +For me, on a system without gdb, the current version looks like + +T070-insert: Testing "notmuch insert" + missing prerequisites: gdb(1) + SKIP all tests in T070-insert + +This seems OK to me? + +Of course you're right that moving it forward to only skip the gdb +requiring tests is the right thing to do, and in that setting having a +skipped message for all 10 skipped tests is a bit ugly. OTOHO your +version doesn't give any output at all, which seems not perfect either. +