From: Shawn O. Pearce <spearce@spearce.org>
Date: Wed, 31 Jan 2007 07:24:44 +0000 (-0500)
Subject: Don't coredump on bad refs in update-server-info.
X-Git-Tag: v1.5.0-rc3~11
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=76f8a302c73d7fe26b2034ab4d1dde64de39c8df;p=git.git

Don't coredump on bad refs in update-server-info.

Apparently if we are unable to parse an object update-server-info
coredumps, as it doesn't bother to check the return value of its
call to parse_object.

Instead of coredumping, skip the ref.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
---

diff --git a/server-info.c b/server-info.c
index 6cd38be32..f9be5a7f6 100644
--- a/server-info.c
+++ b/server-info.c
@@ -10,6 +10,8 @@ static FILE *info_ref_fp;
 static int add_info_ref(const char *path, const unsigned char *sha1, int flag, void *cb_data)
 {
 	struct object *o = parse_object(sha1);
+	if (!o)
+		return -1;
 
 	fprintf(info_ref_fp, "%s	%s\n", sha1_to_hex(sha1), path);
 	if (o->type == OBJ_TAG) {