From: Daniel Schoepe Date: Mon, 10 Aug 2015 12:57:42 +0000 (+0200) Subject: Re: [PATCH 4/5] cli: add global option "--uuid" X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=76cc9c755baeb4efd1467b92d00c99a18aa975e3;p=notmuch-archives.git Re: [PATCH 4/5] cli: add global option "--uuid" --- diff --git a/38/c0656520c6535f8d8eff7bc0073a90dcd5eabc b/38/c0656520c6535f8d8eff7bc0073a90dcd5eabc new file mode 100644 index 000000000..31496dda5 --- /dev/null +++ b/38/c0656520c6535f8d8eff7bc0073a90dcd5eabc @@ -0,0 +1,102 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id B9F056DE17DD + for ; Mon, 10 Aug 2015 05:57:52 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.11 +X-Spam-Level: +X-Spam-Status: No, score=-0.11 tagged_above=-999 required=5 tests=[AWL=0.097, + DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, + RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SORBS_WEB=0.614, SPF_PASS=-0.001] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id L90iNwty3OUc for ; + Mon, 10 Aug 2015 05:57:51 -0700 (PDT) +Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com + [209.85.212.179]) + by arlo.cworth.org (Postfix) with ESMTPS id BD1826DE0244 + for ; Mon, 10 Aug 2015 05:57:50 -0700 (PDT) +Received: by wicne3 with SMTP id ne3so134840297wic.1 + for ; Mon, 10 Aug 2015 05:57:49 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=schoepe.org; s=google; + h=from:to:subject:in-reply-to:references:user-agent:date:message-id + :mime-version:content-type; + bh=rWLAZme0IC0gQkoSTJAuBGah4CblVBMkoG6eIk9mqIA=; + b=X/vNIM/x8oSawpGpB/A2yEZz+PxURNVWvXgRqPswdNn3aOG5qPdjboG69uXI5VYsQY + oQIvqJmSIdiRWJ03X1ScmXP4rql83mwzwukPnu0pO33Kc0+4zD4C3HWDiy1r0OpzFhop + WZbDIn6QnaXIgb6/JTZdrWFW2gszVYsX+Lf2A= +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:subject:in-reply-to:references + :user-agent:date:message-id:mime-version:content-type; + bh=rWLAZme0IC0gQkoSTJAuBGah4CblVBMkoG6eIk9mqIA=; + b=lBHAZbXG8IkPMK6BhQY4OGw0vnHaV2ECITf2Mwh1Wwgc33eIzHB5Ip8RfNYdCBfqTr + r2P8YszoQJo9xSPB+A16fsHP2fwVwh6F5OBBeSNDRzRHKFeEYFciYNEYgH2sElaKoVmz + EyW7dVnWcENaNohcfydNJFxuVIJERuUUrWRxYCoYmTCHEWLZ5YqSxVqukvn5FjvWZSIH + gR4i5FO64FcYFQk1kCuqcL8c1ikbsbgOKTVeyEHs7LPnrB9/VWcPTti51TRuhBz/YTXA + bK9PhhDromuY+YoAf+dE2ltb2tX7zjQGOOzI5tjia0j4qzV4dqcxERmwOszoeeKBMbu4 + dmCw== +X-Gm-Message-State: + ALoCoQmIwIp5IVY8NHdcC5rN+S5jpY6wdWTZhWFhhThlge/lKg40NWA1y+SI5vddbLoZxglvI5x2 +X-Received: by 10.180.21.200 with SMTP id x8mr21967985wie.59.1439211468813; + Mon, 10 Aug 2015 05:57:48 -0700 (PDT) +Received: from localhost (ip-80-226-24-12.vodafone-net.de. [80.226.24.12]) + by smtp.gmail.com with ESMTPSA id fa8sm13700582wib.14.2015.08.10.05.57.45 + (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Mon, 10 Aug 2015 05:57:47 -0700 (PDT) +From: Daniel Schoepe +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [PATCH 4/5] cli: add global option "--uuid" +In-Reply-To: <87r3nbl6p3.fsf@maritornes.cs.unb.ca> +References: <1439112285-6681-1-git-send-email-david@tethera.net> + <1439112285-6681-5-git-send-email-david@tethera.net> + <87fv3rtray.fsf@schoepe.localhost> <87r3nbl6p3.fsf@maritornes.cs.unb.ca> +User-Agent: Notmuch/0.20.2+58~g20ed908 (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-unknown-linux-gnu) +Date: Mon, 10 Aug 2015 14:57:42 +0200 +Message-ID: <87d1yvti61.fsf@schoepe.localhost> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 10 Aug 2015 12:57:52 -0000 + +On Mon, 10 Aug 2015 13:32 +0200, David Bremner wrote: +> So compacting is in fact a bit of a strange case, it preserves the +> lastmod counters (because those are just terms on documents), but not +> the uuid. This means from notmuch point of view have no programmatic way +> to know that we can trust the lastmod data, i.e. no way to distinguish a +> previous notmuch-compact from "notmuch dump && rm the database && +> notmuch new && notmuch restore". On the other hand, I _think_ we could +> promise the user that lastmod data is preserved by compacting; they +> would just have to tell whatever external tool to ignore uuid errors and +> perhaps set the new uuid. + +Yeah, I think it's reasonable to assume that if the user will delete and +recreate the database, they will also perform the necessary +reinitialization of whatever tool makes use of lastmod / UUID. I guess +this also means that tools often only care about lastmod values and not +the UUID, to allow for compacting without thinking the database is +completely different now. + +Another option is to include lastmod values in the output of +notmuch-dump. Doing that in a clean way might be hard though and I think +this shouldn't be part of this series (which looks fine to me now). + +Best regards, +Daniel