From: David Bremner <david@tethera.net>
Date: Sat, 4 May 2013 00:28:09 +0000 (+2100)
Subject: Re: [PATCH] lib/message.cc: stale pointer bug (v3)
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=7686306935787f148a14a15ab4fa0604dc38751b;p=notmuch-archives.git

Re: [PATCH] lib/message.cc: stale pointer bug (v3)
---

diff --git a/fd/d65ff84daae94609faffe4ad73a92218833f9e b/fd/d65ff84daae94609faffe4ad73a92218833f9e
new file mode 100644
index 000000000..bd1f423b8
--- /dev/null
+++ b/fd/d65ff84daae94609faffe4ad73a92218833f9e
@@ -0,0 +1,71 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 9EB71431FAF
+	for <notmuch@notmuchmail.org>; Fri,  3 May 2013 17:43:59 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: -2.3
+X-Spam-Level: 
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5
+	tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id ftxdM4DcicoI for <notmuch@notmuchmail.org>;
+	Fri,  3 May 2013 17:43:55 -0700 (PDT)
+Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21])
+	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id 96B6D431FB6
+	for <notmuch@notmuchmail.org>; Fri,  3 May 2013 17:43:54 -0700 (PDT)
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
+	by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id r440SGdB030720;
+	Fri, 3 May 2013 21:28:16 -0300
+Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net
+	([156.34.82.78] helo=zancas.localnet)
+	by tesseract.cs.unb.ca with esmtpsa
+	(TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80)
+	(envelope-from <david@tethera.net>)
+	id 1UYQKl-0005K5-Ii; Fri, 03 May 2013 21:28:16 -0300
+Received: from bremner by zancas.localnet with local (Exim 4.80)
+	(envelope-from <david@tethera.net>)
+	id 1UYQKf-0004pn-Es; Fri, 03 May 2013 21:28:09 -0300
+From: David Bremner <david@tethera.net>
+To: Vladimir.Marek@oracle.com, notmuch@notmuchmail.org
+Subject: Re: [PATCH] lib/message.cc: stale pointer bug (v3)
+In-Reply-To: <1367505102-12860-1-git-send-email-Vladimir.Marek@oracle.com>
+References: <1367505102-12860-1-git-send-email-Vladimir.Marek@oracle.com>
+User-Agent: Notmuch/0.15.2+84~g12d5e4e (http://notmuchmail.org) Emacs/24.2.1
+	(x86_64-pc-linux-gnu)
+Date: Fri, 03 May 2013 21:28:09 -0300
+Message-ID: <878v3vvbae.fsf@zancas.localnet>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-Spam_bar: -
+Cc: Vladimir Marek <vlmarek@volny.cz>
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sat, 04 May 2013 00:44:00 -0000
+
+Vladimir.Marek@oracle.com writes:
+
+> From: Vladimir Marek <vlmarek@volny.cz>
+>
+> Xapian::TermIterator::operator* returns std::string which is destroyed
+> as soon as (*i).c_str() finishes. The remembered pointer 'term' then
+> references invalid memory.
+
+Pushed,
+
+d