From: Carl Worth <cworth@cworth.org>
Date: Thu, 28 Oct 2010 00:58:19 +0000 (-0700)
Subject: emacs: Remove non-interactive call of goto-line
X-Git-Tag: 0.4~45
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=75f703e7c2fe33920342c1bc534d19935c1e3513;p=notmuch.git

emacs: Remove non-interactive call of goto-line

As the emacs compiler warns, the goto-line function is only intended for
interactive use. Instead use the approach recommended in the goto-line
documentation to avoid this.
---

diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index 8d69fc87..ff9b519b 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -575,9 +575,10 @@ This function advances the next thread when finished."
 			(if (and atbob
 				 (not (string= notmuch-search-target-thread "found")))
 			    (set 'never-found-target-thread t))))))
-	      (if (and never-found-target-thread
+	      (when (and never-found-target-thread
 		       notmuch-search-target-line)
-		  (goto-line notmuch-search-target-line)))))))
+		  (goto-char (point-min))
+		  (forward-line (1- notmuch-search-target-line))))))))
 
 (defcustom notmuch-search-line-faces nil
   "Tag/face mapping for line highlighting in notmuch-search.