From: David Bremner <bremner@unb.ca>
Date: Sat, 24 Aug 2013 09:41:05 +0000 (+0200)
Subject: Re: [PATCH v3 08/10] notmuch-config: use strchr(), not index() (Solaris support)
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=7508ffe6c9a99dcf82ee3887290cd0619629047b;p=notmuch-archives.git

Re: [PATCH v3 08/10] notmuch-config: use strchr(), not index() (Solaris support)
---

diff --git a/49/6b57b60110695b03f27c281d331760fcef6a31 b/49/6b57b60110695b03f27c281d331760fcef6a31
new file mode 100644
index 000000000..2acb30fa4
--- /dev/null
+++ b/49/6b57b60110695b03f27c281d331760fcef6a31
@@ -0,0 +1,65 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 1D525431FD7
+	for <notmuch@notmuchmail.org>; Sat, 24 Aug 2013 02:41:16 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id G7VQMqJqdSP9 for <notmuch@notmuchmail.org>;
+	Sat, 24 Aug 2013 02:41:11 -0700 (PDT)
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
+	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id 060DA431FBF
+	for <notmuch@notmuchmail.org>; Sat, 24 Aug 2013 02:41:11 -0700 (PDT)
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
+	(envelope-from <david@tethera.net>)
+	id 1VDALG-0007uE-JY; Sat, 24 Aug 2013 06:41:10 -0300
+Received: (nullmailer pid 2914 invoked by uid 1000); Sat, 24 Aug 2013
+	09:41:05 -0000
+From: David Bremner <bremner@unb.ca>
+To: Blake Jones <blakej@foo.net>, notmuch@notmuchmail.org
+Subject: Re: [PATCH v3 08/10] notmuch-config: use strchr(), not index()
+	(Solaris support)
+In-Reply-To: <1352859005-18631-9-git-send-email-blakej@foo.net>
+References: <1352859005-18631-1-git-send-email-blakej@foo.net>
+	<1352859005-18631-9-git-send-email-blakej@foo.net>
+User-Agent: Notmuch/0.16 (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-pc-linux-gnu)
+Date: Sat, 24 Aug 2013 11:41:05 +0200
+Message-ID: <87a9k7o28e.fsf@maritornes.cs.unb.ca>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sat, 24 Aug 2013 09:41:16 -0000
+
+Blake Jones <blakej@foo.net> writes:
+
+> notmuch-config.c has the only use of the function named "index()" in the
+> notmuch source.  Several other places use the equivalent function
+> "strchr()"; this patch just fixes notmuch-config.c to use strchr()
+> instead.  (Solaris needs to include <strings.h> to get the prototype for
+> index(), and notmuch-config.c was failing to include that header, so it
+> wasn't compiling as-is.)
+
+Pushed this patch, sorry about the delay
+
+d