From: Zac Medico <zmedico@gentoo.org>
Date: Thu, 12 Feb 2009 23:12:41 +0000 (-0000)
Subject: Add a new "portage.internal" warning for prepalldocs usage since the council
X-Git-Tag: v2.2_rc24~199
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=7411bc1bde9734df9eb00b19044929e4047b8652;p=portage.git

Add a new "portage.internal" warning for prepalldocs usage since the council
ruled that it shouldn't be used in ebuilds. Thanks to Petteri Räty
<betelgeuse@g.o> for the initial patch.

svn path=/main/trunk/; revision=12603
---

diff --git a/bin/repoman b/bin/repoman
index 3c062d7fd..7bbb1525e 100755
--- a/bin/repoman
+++ b/bin/repoman
@@ -317,6 +317,7 @@ qahelp={
 	"metadata.missing":"Missing metadata.xml files",
 	"metadata.bad":"Bad metadata.xml files",
 	"metadata.warning":"Warnings in metadata.xml files",
+	"portage.internal":"The ebuild uses an internal Portage function",
 	"virtual.versioned":"PROVIDE contains virtuals with versions",
 	"virtual.exists":"PROVIDE contains existing package names",
 	"virtual.unavailable":"PROVIDE contains a virtual which contains no profile default",
diff --git a/man/repoman.1 b/man/repoman.1
index 5b5aec6ff..aca5587c0 100644
--- a/man/repoman.1
+++ b/man/repoman.1
@@ -270,6 +270,9 @@ Missing metadata.xml files
 .B metadata.warning
 Warnings in metadata.xml files
 .TP
+.B portage.internal
+The ebuild uses an internal Portage function
+.TP
 .B upstream.workaround
 The ebuild works around an upstream bug, an upstream bug should be filed and
 tracked in bugs.gentoo.org
diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py
index e89020980..aee6d7c97 100644
--- a/pym/repoman/checks.py
+++ b/pym/repoman/checks.py
@@ -339,6 +339,15 @@ class WantAutoDefaultValue(LineCheck):
 			return 'WANT_AUTO' + m.group(1) + \
 				' redundantly set to default value "latest" on line: %d'
 
+class PortageInternal(LineCheck):
+	"""
+	In February 2009 the Gentoo council ruled that
+	prepalldocs is a Portage internal.
+	"""
+	repoman_check_name = 'portage.internal'
+	re = re.compile(r'[^#]*\bprepalldocs\b')
+	error = errors.PREPALLDOCS_ERROR
+
 _constant_checks = tuple((c() for c in (
 	EbuildHeader, EbuildWhitespace, EbuildQuote,
 	EbuildAssignment, EbuildUselessDodoc,
@@ -346,7 +355,7 @@ _constant_checks = tuple((c() for c in (
 	EbuildPatches, EbuildQuotedA,
 	IUseUndefined, ImplicitRuntimeDeps, InheritAutotools,
 	EMakeParallelDisabled, DeprecatedBindnowFlags,
-	WantAutoDefaultValue)))
+	WantAutoDefaultValue, PortageInternal)))
 
 def run_checks(contents, pkg):
 	checks = _constant_checks
diff --git a/pym/repoman/errors.py b/pym/repoman/errors.py
index 7f45bea21..205913951 100644
--- a/pym/repoman/errors.py
+++ b/pym/repoman/errors.py
@@ -15,3 +15,4 @@ PATCHES_ERROR = 'PATCHES is not a bash array on line: %d'
 REDUNDANT_CD_S_ERROR = 'Ebuild has redundant cd ${S} statement on line: %d'
 EMAKE_PARALLEL_DISABLED = 'Upstream parallel compilation bug (ebuild calls emake -j1 on line: %d)'
 DEPRECATED_BINDNOW_FLAGS = 'Deprecated bindnow-flags call on line: %d'
+PREPALLDOCS_ERROR = 'prepalldocs called on line: %d'