From: Felipe Contreras Date: Tue, 16 Apr 2013 18:38:57 +0000 (+1900) Subject: Re: [PATCH] debian: package ruby bindings X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=7377d13eca3a890d690ec2abbf424dade38d731f;p=notmuch-archives.git Re: [PATCH] debian: package ruby bindings --- diff --git a/3b/90926aef89c4d4aa6e0b7c1d1feb9592b3a3cc b/3b/90926aef89c4d4aa6e0b7c1d1feb9592b3a3cc new file mode 100644 index 000000000..5a6c3d803 --- /dev/null +++ b/3b/90926aef89c4d4aa6e0b7c1d1feb9592b3a3cc @@ -0,0 +1,109 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 71559431FBD + for ; Tue, 16 Apr 2013 11:39:01 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id fvDQTwEJyPy8 for ; + Tue, 16 Apr 2013 11:39:00 -0700 (PDT) +Received: from mail-la0-f52.google.com (mail-la0-f52.google.com + [209.85.215.52]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id C99E2431FAF + for ; Tue, 16 Apr 2013 11:38:59 -0700 (PDT) +Received: by mail-la0-f52.google.com with SMTP id ek20so752692lab.11 + for ; Tue, 16 Apr 2013 11:38:58 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=mime-version:x-received:in-reply-to:references:date:message-id + :subject:from:to:cc:content-type; + bh=SDOdvLWwYcRQGulMFu+NKGVBSvAcFvSoKp1zMAPQSdY=; + b=Gd4ZGDsTSFd1OHaMCTqUxaqpbsuRqtVgIvwfda6+gG2qtyb/vufi1TyvWzdx29Be1U + b+tYwCghi/fUOAdImevQwCf7m2Mr29WGwtjFkiMWkA4wgJ/okkSzZ9Bs9TrpIM5Q6qgl + gl3zWDwWPxMbSn1V5dfuVrZKsvSQ1UeOCCAyvxfFJJa/ECltC9RxCCS6iIhsIRw5fiR3 + hjo2HeTB3h/lyL+6Upc+o2u40v7ECC7JeERXzS65ufr43tNH5A1bLSaQ3Spgn2+kt/A/ + kaW5Wc22TwvO5ObTNFp82vOLMuuZQXcqcWVe3p1aiQUIaPm2qqid11UT003VDBQedV2z + y+8w== +MIME-Version: 1.0 +X-Received: by 10.152.3.137 with SMTP id c9mr1847991lac.5.1366137538243; Tue, + 16 Apr 2013 11:38:58 -0700 (PDT) +Received: by 10.114.59.210 with HTTP; Tue, 16 Apr 2013 11:38:57 -0700 (PDT) +In-Reply-To: <871uact7kb.fsf@zancas.localnet> +References: <1365031678-25188-1-git-send-email-felipe.contreras@gmail.com> + <87y5clte1j.fsf@zancas.localnet> + + <871uact7kb.fsf@zancas.localnet> +Date: Tue, 16 Apr 2013 13:38:57 -0500 +Message-ID: + +Subject: Re: [PATCH] debian: package ruby bindings +From: Felipe Contreras +To: David Bremner +Content-Type: text/plain; charset=UTF-8 +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 16 Apr 2013 18:39:01 -0000 + +On Mon, Apr 15, 2013 at 5:24 AM, David Bremner wrote: +> Felipe Contreras writes: +>>> The package is still installing files into /usr/local, which is a +>>> violation of debian policy 9.1.2 +>>> +>>> It's a good idea to run "lintian" on the resulting debian packages; +>>> that's how I caught the problem with /usr/local. +>> +>> Tell that to debian maintainers who configure ruby that way: +> +> [ ruby config deleted ] +> +> I don't know if there is a bug in the Debian ruby package or not, but +> that does not change whether our package is allowed to install into +> /usr/local. I suspect the argument is that those defaults are sensible +> for admins installing ruby packages on their own systems without using +> the debian package system. + +I asked the debian ruby packages and looked everywhere, but there was +no guidance at all. Nonetheless I think this does the trick: + +--- a/debian/notmuch-ruby.install ++++ b/debian/notmuch-ruby.install +@@ -1 +1 @@ +-usr/local/lib/site_ruby/*/*/notmuch.so ++usr/lib/ruby/vendor_ruby/*/*/notmuch.so +diff --git a/debian/rules b/debian/rules +index 1dd59d2..fed680b 100755 +--- a/debian/rules ++++ b/debian/rules +@@ -12,7 +12,7 @@ override_dh_auto_build: + dh_auto_build + dh_auto_build --sourcedirectory bindings/python + cd bindings/python && $(python3_all) setup.py build +- cd bindings/ruby && ruby extconf.rb && make ++ cd bindings/ruby && ruby extconf.rb --vendor && make + $(MAKE) -C contrib/notmuch-mutt + + override_dh_auto_clean: + +Cheers. + +-- +Felipe Contreras