From: Bartosz Telenczuk Date: Mon, 2 Feb 2015 23:39:09 +0000 (+0100) Subject: RE: [PATCH 1/4] VIM: implemented message folding in thread view X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=7348b8c3070da079a363fb1b4eb0589c974c750c;p=notmuch-archives.git RE: [PATCH 1/4] VIM: implemented message folding in thread view --- diff --git a/86/6badc5a2199f8e9bed9118269d0bdb07eacf50 b/86/6badc5a2199f8e9bed9118269d0bdb07eacf50 new file mode 100644 index 000000000..ca9091f2b --- /dev/null +++ b/86/6badc5a2199f8e9bed9118269d0bdb07eacf50 @@ -0,0 +1,73 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 50357431FC7 + for ; Mon, 2 Feb 2015 15:39:24 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 2.438 +X-Spam-Level: ** +X-Spam-Status: No, score=2.438 tagged_above=-999 required=5 + tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id E7fN1PPnm6c6 for ; + Mon, 2 Feb 2015 15:39:15 -0800 (PST) +Received: from smtp.webfaction.com (mail6.webfaction.com [74.55.86.74]) + by olra.theworths.org (Postfix) with ESMTP id 94069431FC2 + for ; Mon, 2 Feb 2015 15:39:15 -0800 (PST) +Received: from localhost (87-231-242-54.rev.numericable.fr [87.231.242.54]) + by smtp.webfaction.com (Postfix) with ESMTP id 6A6B359A3FD3; + Mon, 2 Feb 2015 23:39:11 +0000 (UTC) +Date: Tue, 03 Feb 2015 00:39:09 +0100 +From: Bartosz Telenczuk +To: Franz Fellner , + Bartosz +Message-ID: + <54d00a9d68d9c_47c3ff0b58781fc89@bartels-MacBook-Pro.local.notmuch> +In-Reply-To: <54c1608bd22a9_67b66d530832@TP_L520.notmuch> +References: <1420891384-992-1-git-send-email-telenczuk@unic.cnrs-gif.fr> + <1420891384-992-2-git-send-email-telenczuk@unic.cnrs-gif.fr> + <54c1608bd22a9_67b66d530832@TP_L520.notmuch> +Subject: RE: [PATCH 1/4] VIM: implemented message folding in thread view +Mime-Version: 1.0 +Content-Type: text/plain; + charset=utf-8 +Content-Transfer-Encoding: 7bit +Cc: notmuch@notmuchmail.org, Bartosz +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 02 Feb 2015 23:39:24 -0000 + +Hi Franz, + +> We already had folding via syntax in Ians fork. It turned out to be not that great. +> https://github.com/imain/notmuch-vim/issues/3 + +Ah all right, I just thought syntax fold would be more elegant. + +> In short: +> Those syntax fold marks are for one specific notmuch-show-buffer. If you open a second show-buffer those +> new fold marks will overwrite the ones from the previous show-buffer. Switching between those two show-buffers +> will spin up CPU for quite some time and completely lock vim. + +True, I can reproduce this bug in my implementation. + +> It also would help a lot if we could reoranize the sources as in Ians fork. Would simplify testing, coding (proper filetype) and backporting patches. + +Agree. We should come up with a plan how to integrate the changes back into notmuch. Do you have any ideas? + +Cheers, + +Bartosz