From: David Bremner Date: Mon, 8 Apr 2013 21:56:26 +0000 (+2100) Subject: Re: [PATCH] lib: Add a new prefix "list" to the search-terms syntax X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=72da12c6963d9345877ef861aca2a7d8a7d66919;p=notmuch-archives.git Re: [PATCH] lib: Add a new prefix "list" to the search-terms syntax --- diff --git a/34/4d2a4631b248fb0fc1f29f9a1d1886b083f580 b/34/4d2a4631b248fb0fc1f29f9a1d1886b083f580 new file mode 100644 index 000000000..f89dec9d6 --- /dev/null +++ b/34/4d2a4631b248fb0fc1f29f9a1d1886b083f580 @@ -0,0 +1,86 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id BFD3A431FB6 + for ; Mon, 8 Apr 2013 14:56:44 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 3Dr2njDAmnJT for ; + Mon, 8 Apr 2013 14:56:44 -0700 (PDT) +Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 3097A431FAE + for ; Mon, 8 Apr 2013 14:56:44 -0700 (PDT) +Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net + ([156.34.82.78] helo=zancas.localnet) + by tesseract.cs.unb.ca with esmtpsa + (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) + (envelope-from ) + id 1UPK3E-0003gH-Nk; Mon, 08 Apr 2013 18:56:37 -0300 +Received: from bremner by zancas.localnet with local (Exim 4.80) + (envelope-from ) + id 1UPK38-0005iE-Ua; Mon, 08 Apr 2013 18:56:26 -0300 +From: David Bremner +To: "Alexey I. Froloff" +Subject: Re: [PATCH] lib: Add a new prefix "list" to the search-terms syntax +In-Reply-To: <20130408100336.GA1806@raorn.name> +References: <1364996763-19718-1-git-send-email-raorn@raorn.name> + <874nfjj2lo.fsf@zancas.localnet> <20130408100336.GA1806@raorn.name> +User-Agent: Notmuch/0.15.2+73~g1c450ec (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-pc-linux-gnu) +Date: Mon, 08 Apr 2013 18:56:26 -0300 +Message-ID: <877gkchek5.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-Spam_bar: - +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 08 Apr 2013 21:56:44 -0000 + +"Alexey I. Froloff" writes: + +> On Sat, Apr 06, 2013 at 08:54:59AM -0300, David Bremner wrote: +>> On the other hand, _notmuch_message_gen_terms does return a status. I +>> agree that currently this status is not useful, but that could change in +>> the future. I also agree that the existing code does the same thing in +>> a few places, but I think it's better not to introduce more. +> Well, this is an adaptation of earlier patch, posted in this list +> some time ago. + +Sure, no blame attaches. But somebody still needs to fix the patch or +convince us it doesn't need fixing. + +> Personally I see no reason in indexing list description. + +That's an independent question. I guess there is the question of how +much overhead this introduces into + +>> Any objections to the list: syntax? The only issue I see is that at +>> some point we will probably add a generic header search syntax, and this +>> implicitly says list-id is more important/common than other headers. +> Actual list ID differs from List-Id header value. I can't give +> an example of other message header with similar syntax other from +> From/To/Cc, but those headers already specially processed. + +OK, that part seems relatively convincing to me. + +d