From: W. Trevor King Date: Wed, 24 Sep 2014 19:44:13 +0000 (+1700) Subject: Re: [PATCH] lib: Simplify close and codify aborting atomic section X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=72ba16d07057f8bbf8f7a713205173eab2b36769;p=notmuch-archives.git Re: [PATCH] lib: Simplify close and codify aborting atomic section --- diff --git a/7d/ed358bcc78c22dbd63fb1b9b64aa4418388bcb b/7d/ed358bcc78c22dbd63fb1b9b64aa4418388bcb new file mode 100644 index 000000000..b18f9cdc3 --- /dev/null +++ b/7d/ed358bcc78c22dbd63fb1b9b64aa4418388bcb @@ -0,0 +1,127 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 0F6B1431FB6 + for ; Wed, 24 Sep 2014 12:44:21 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.1 +X-Spam-Level: +X-Spam-Status: No, score=-0.1 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id Gw4lKO39OW5W for ; + Wed, 24 Sep 2014 12:44:17 -0700 (PDT) +Received: from resqmta-po-02v.sys.comcast.net (resqmta-po-02v.sys.comcast.net + [96.114.154.161]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 25DD5431FAF + for ; Wed, 24 Sep 2014 12:44:17 -0700 (PDT) +Received: from resomta-po-10v.sys.comcast.net ([96.114.154.234]) + by resqmta-po-02v.sys.comcast.net with comcast + id v7kC1o00153iAfU017kFnz; Wed, 24 Sep 2014 19:44:15 +0000 +Received: from odin.tremily.us ([24.18.63.50]) + by resomta-po-10v.sys.comcast.net with comcast + id v7kD1o00N152l3L017kDvK; Wed, 24 Sep 2014 19:44:15 +0000 +Received: by odin.tremily.us (Postfix, from userid 1000) + id 49D2D13AAFC2; Wed, 24 Sep 2014 12:44:13 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tremily.us; s=odin; + t=1411587853; bh=iLJ4ws2pxI4j3fTGEnUshKIpD9JjbfMumb777C2ZsDA=; + h=Date:From:To:Cc:Subject:References:In-Reply-To; + b=E1/V5+Yf1R7UBe9FeaC0lcEVxjd4EbSPe2vyZLjiP44QuKpeO8O+8Gr99CzHpAfKo + 1lCiq30UVkK/GKKnPTEU9IRenQO2G1zeF41avv7D2XassRIX1MmpgCkJpEwZL9pM9H + 0nu1oI3/9KuOCHgue+5KinqRjiTlpl7jUU5GH+aA= +Date: Wed, 24 Sep 2014 12:44:13 -0700 +From: "W. Trevor King" +To: David Bremner +Subject: Re: [PATCH] lib: Simplify close and codify aborting atomic section +Message-ID: <20140924194413.GC20130@odin.tremily.us> +References: <1411400615-20934-1-git-send-email-amdragon@mit.edu> + <20140922165954.GI20827@odin.tremily.us> + <20140922185050.GB7970@csail.mit.edu> + <20140922190022.GO20827@odin.tremily.us> + <87iokc28mg.fsf@maritornes.cs.unb.ca> + <20140924181844.GB20130@odin.tremily.us> + <87d2ak253z.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: multipart/signed; micalg=pgp-sha1; + protocol="application/pgp-signature"; boundary="NU0Ex4SbNnrxsi6C" +Content-Disposition: inline +In-Reply-To: <87d2ak253z.fsf@maritornes.cs.unb.ca> +OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8; + url=http://tremily.us/pubkey.txt +User-Agent: Mutt/1.5.23 (2014-03-12) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; + s=q20140121; t=1411587855; + bh=iLJ4ws2pxI4j3fTGEnUshKIpD9JjbfMumb777C2ZsDA=; + h=Received:Received:Received:Date:From:To:Subject:Message-ID: + MIME-Version:Content-Type; + b=mL03OZxm4t+IMgUaruRnmHlzQzrYD90s/yJlWj0WIVHvS92u9DbavCiX5OV1Hii7K + J1/maaxZB53WHHeuVj04CUMzQM0l+ka1fohOCuRsOd2rTAakMOlAIYg2RPm4mC06xF + jG6aK+e6/x8esYMpy69Jf6XHDsH4RecfLwKHZ1xxlYJ0eo2Vp8F1orTAVpAFrTosFL + 6NdMUqYgb5693eEoeey4Ly7uKj1099DE1ST9ZBcFcQGeaktiIXVyRBnNPXcrCQpsgT + qI062U0R2Yhvkw5ikU3M517kZEK103wWkkEooO2VL+G28ay75K5BHF89J63nSVwnta + WlhOwzgV3Wi1Q== +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 24 Sep 2014 19:44:21 -0000 + + +--NU0Ex4SbNnrxsi6C +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +Content-Transfer-Encoding: quoted-printable + +On Wed, Sep 24, 2014 at 09:25:20PM +0200, David Bremner wrote: +> I think the fact that you have to close the notmuch database (when +> not using begin/end atomic) to get a commit is surprising for many +> people, so it would be nice to make that clearer somehow. + +It looks like Xapian is GPLv2+, so we should just be able to +copy/paste/edit the line I quoted from the Xapian docs. + +Cheers, +Trevor + +--=20 +This email may be signed or encrypted with GnuPG (http://www.gnupg.org). +For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy + +--NU0Ex4SbNnrxsi6C +Content-Type: application/pgp-signature; name="signature.asc" +Content-Description: OpenPGP digital signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v2 + +iQIcBAEBAgAGBQJUIx8LAAoJEG8/JgBt8ol8LIcP/AnDOKGu2BuzoEpcI19qyyo2 +ajkUaGWOF/amUJ99Ll3GLjpyBx5HduI9AwfHEqzHnbKBUl0Tnd0s6JWByWq1NtTa +ejRb04aBQyL78yOl9u2YdnTvp/EttAntIU1sX9mlpuPZDBxwq7lRl8Jl1ywFuzeT +48FUH/7XyYdwgXE8P2iyXGkb2bjXAhFMXSPAKFMWkn+dYYiyjIDzK94VlRXS4DeH +yRU4wLQU/Ra5c/ITw0//eT670dyjIuX8+OXdND1fp5ejX160oRb/vInvHfXQiS0z +FNm8aWfSt2S36aeUkeXq0VdkJh5CYJe92/Ah6DO5RBvb5QDa8l48BSKW97cYI38Y +7NiVcwBT4lkxOOtdX9XG42vL9atFF4P4wC4879FNpaMGGOegXyNJsJQ6LiAH23zQ +8R5JDRjkDNr0OU4aZdP+9E4hqS7afTBTLj2oP+n84aGI9Itwo51EcqMjgv9Ta9Pr +GVAHvpYmEkKZG5PJjqojRRFxIa9xqS0h9m+hibYHkgYn5X39xAjTqKVmv8/RUTxb +jOMsv/FxAsDD3XuPiqBGCKslFOJcs48pB4oeMttSvFvQwHTgtVzukNNITqFb8Q4P +z/gCG8vlKHo+u8j+fa6fI7189ltSG3UOpu2sqeSXjlWa0+OaVrA4RgoG+Yu6mAsJ +RGK0VnIAn8VTZQqRwalX +=cFZi +-----END PGP SIGNATURE----- + +--NU0Ex4SbNnrxsi6C--