From: Tom Yu <tlyu@mit.edu>
Date: Tue, 15 Jul 2008 21:43:35 +0000 (+0000)
Subject: krb5_get_cred_via_tkt() should null out_cred on errors
X-Git-Tag: krb5-1.7-alpha1~596
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=72a0f5dceab710bb4a634add8e90ac7acbb183df;p=krb5.git

krb5_get_cred_via_tkt() should null out_cred on errors

Helper function krb5_kdcrep2creds(), called from
krb5_get_cred_via_tkt(), should null its output pointer after freeing
allocated memory, to avoid returning an invalid pointer.

ticket: new
tags: pullup
target_version: 1.6.4
component: krb5-libs

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20527 dc483132-0cff-0310-8789-dd5450dbe970
---

diff --git a/src/lib/krb5/krb/gc_via_tkt.c b/src/lib/krb5/krb/gc_via_tkt.c
index 7ecd2813d..3a9c21818 100644
--- a/src/lib/krb5/krb/gc_via_tkt.c
+++ b/src/lib/krb5/krb/gc_via_tkt.c
@@ -97,6 +97,7 @@ cleanup_keyblock:
 
 cleanup:
     free (*ppcreds);
+    *ppcreds = NULL;
     return retval;
 }