From: Jani Nikula Date: Sat, 22 Nov 2014 11:31:04 +0000 (+0200) Subject: Re: [PATCH v2 2/2] test: Add test for correct naming of author. X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=71d4cc4cefd23c2449c6aec628c04b19f553dd0d;p=notmuch-archives.git Re: [PATCH v2 2/2] test: Add test for correct naming of author. --- diff --git a/c8/3987a6b57848c1ab1fbb2df49aabb46101eea2 b/c8/3987a6b57848c1ab1fbb2df49aabb46101eea2 new file mode 100644 index 000000000..5e0c763af --- /dev/null +++ b/c8/3987a6b57848c1ab1fbb2df49aabb46101eea2 @@ -0,0 +1,112 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1D215431FBF + for ; Sat, 22 Nov 2014 03:31:13 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id BlX87GIVQd8Y for ; + Sat, 22 Nov 2014 03:31:09 -0800 (PST) +Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com + [209.85.212.176]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 8F338431FBC + for ; Sat, 22 Nov 2014 03:31:09 -0800 (PST) +Received: by mail-wi0-f176.google.com with SMTP id ex7so1585320wid.9 + for ; Sat, 22 Nov 2014 03:31:08 -0800 (PST) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:subject:in-reply-to:references + :user-agent:date:message-id:mime-version:content-type; + bh=i+lBpNygSjsO4VCBmuo/aSYo0tt2gmCP3SHsrLMaLD8=; + b=kx1hZnupSQ0IXsMcWndSdMrjiODtpaeeEVBrELEN+fwQA/5Mqaju26CzUcHPgn0wGk + 7qPeqITbdTrym3B/DZyJu5lsSCBFhJalLC+DV5FtJE2511DfKGS12kE3uPNrn5XQ21BH + FhNhRQeRWdQG4wru6juKtdAqtB+cQ7BvuqB5cRb4QTgYZaeelPukAbJBj+qSZj9eaUCQ + 9lWsVxPH2PnhO4jdt4lon0jJitub1GrTFR3VWcHyXCqnJCawF/TiUSTzCfuVVwdRM2+4 + rqHh+8cxwawuQiHSIdw+Yt5DiM3eR0Uyq/O2vDVSDFlxxNtyZqt20GLC1An+K3ac58uO + eB0w== +X-Gm-Message-State: + ALoCoQnm8B5RoSGjBvtUHVYQOgwW5BAAneN7cLX1fmBJwkv5VoOpbjDSqrbZ7A6ShzZuvV2TqV1i +X-Received: by 10.194.6.227 with SMTP id e3mr16453776wja.107.1416655868455; + Sat, 22 Nov 2014 03:31:08 -0800 (PST) +Received: from localhost (dsl-hkibrasgw2-58c362-144.dhcp.inet.fi. + [88.195.98.144]) by mx.google.com with ESMTPSA id + kn5sm11826804wjb.48.2014.11.22.03.31.07 for + (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Sat, 22 Nov 2014 03:31:07 -0800 (PST) +From: Jani Nikula +To: Jesse Rosenthal , notmuch@notmuchmail.org +Subject: Re: [PATCH v2 2/2] test: Add test for correct naming of author. +In-Reply-To: <1416585462-24558-3-git-send-email-jrosenthal@jhu.edu> +References: <1416585462-24558-1-git-send-email-jrosenthal@jhu.edu> + <1416585462-24558-3-git-send-email-jrosenthal@jhu.edu> +User-Agent: Notmuch/0.19+1~gcffa3cf (http://notmuchmail.org) Emacs/24.4.1 + (x86_64-pc-linux-gnu) +Date: Sat, 22 Nov 2014 13:31:04 +0200 +Message-ID: <87mw7jqxon.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 22 Nov 2014 11:31:13 -0000 + +On Fri, 21 Nov 2014, Jesse Rosenthal wrote: +> This is a new test file, since handling of unusual email addresses +> doesn't seem to fit well in any of our existing tests. + +It would be nice to have this as patch 1/2 annotated with "known broken" +and have the implementation patch fix it. It's nice to see that the +patch actually changes things! ;) + +BR, +Jani. + +> +> Signed-off-by: Jesse Rosenthal +> --- +> test/T205-author-naming.sh | 12 ++++++++++++ +> 1 file changed, 12 insertions(+) +> create mode 100755 test/T205-author-naming.sh +> +> diff --git a/test/T205-author-naming.sh b/test/T205-author-naming.sh +> new file mode 100755 +> index 0000000..cb678ae +> --- /dev/null +> +++ b/test/T205-author-naming.sh +> @@ -0,0 +1,12 @@ +> +#!/usr/bin/env bash +> +test_description="naming of authors with unusual addresses" +> +. ./test-lib.sh +> + +> +test_begin_subtest "Add author with empty quoted real name" +> +add_message '[subject]="author-naming: Initial thread subject"' \ +> + '[date]="Fri, 05 Jan 2001 15:43:56 -0000"' \ +> + '[from]="\"\" "' +> +output=$(notmuch search --sort=oldest-first author-naming and tag:inbox | notmuch_search_sanitize) +> +test_expect_equal "$output" "thread:XXX 2001-01-05 [1/1] address@example.com; author-naming: Initial thread subject (inbox unread)" +> + +> +test_done +> -- +> 2.1.3 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch