From: Zac Medico <zmedico@gentoo.org>
Date: Thu, 31 Jan 2008 06:18:40 +0000 (-0000)
Subject: Check for quoted ${A}. Thanks to maekke for this patch. (trunk r9206)
X-Git-Tag: v2.1.4.1~14
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=70e65f34ca274abb8a81005dc9674e3c9fac9037;p=portage.git

Check for quoted ${A}. Thanks to maekke for this patch. (trunk r9206)

svn path=/main/branches/2.1.2/; revision=9240
---

diff --git a/bin/repoman b/bin/repoman
index fdd57f32c..674aa61fd 100755
--- a/bin/repoman
+++ b/bin/repoman
@@ -1029,9 +1029,20 @@ class Autotools(LineCheck):
 			return ("Direct calls to '%s'" % m.group(2)) + \
 				" instead of using autotools.eclass on line: %d"
 
+class EbuildQuotedA(LineCheck):
+	"""Ensure ebuilds have no quoting around ${A}"""
+
+	repoman_check_name = 'ebuild.minorsyn'
+	a_quoted = re.compile(r'.*\"\$(\{A\}|A)\"')
+
+	def check(self, num, line):
+		match = self.a_quoted.match(line)
+		if match:
+			return "Quoted \"${A}\" on line: %d"
+
 _constant_checks = tuple((c() for c in (Autotools,
 	EbuildQuote, EbuildUselessDodoc, EbuildUselessCdS,
-	EbuildNestedDie)))
+	EbuildNestedDie, EbuildQuotedA)))
 
 def run_checks(contents):
 	for num, line in enumerate(contents):