From: Justus Winter <4winter@informatik.uni-hamburg.de> Date: Tue, 1 Mar 2016 16:46:18 +0000 (+0100) Subject: Re: [PATCH] lib: have two definitions of NOTMUCH_DEPRECATED macro X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=70d69c8c14ef1c79875d75e52f84e08980180320;p=notmuch-archives.git Re: [PATCH] lib: have two definitions of NOTMUCH_DEPRECATED macro --- diff --git a/9a/7d74407d68c3089f451c1f7b995098a5bc3fc9 b/9a/7d74407d68c3089f451c1f7b995098a5bc3fc9 new file mode 100644 index 000000000..e15d74d3d --- /dev/null +++ b/9a/7d74407d68c3089f451c1f7b995098a5bc3fc9 @@ -0,0 +1,84 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 9CA646DE01F7 + for ; Tue, 1 Mar 2016 08:46:24 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 0.001 +X-Spam-Level: +X-Spam-Status: No, score=0.001 tagged_above=-999 required=5 + tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, + RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id B8nNiF5T5Lf0 for ; + Tue, 1 Mar 2016 08:46:22 -0800 (PST) +Received: from mail.cryptobitch.de (cryptobitch.de [88.198.7.68]) + by arlo.cworth.org (Postfix) with ESMTPS id 6E5736DE00DF + for ; Tue, 1 Mar 2016 08:46:22 -0800 (PST) +Received: from thinkbox (p4FD27A8D.dip0.t-ipconnect.de [79.210.122.141]) + (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) + (No client certificate requested) + by mail.cryptobitch.de (Postfix) with ESMTPSA id 0A83D8F94ED; + Tue, 1 Mar 2016 17:46:19 +0100 (CET) +Received: from teythoon by thinkbox with local (Exim 4.84) + (envelope-from ) + id 1aanRC-0006ce-5o; Tue, 01 Mar 2016 17:46:18 +0100 +Content-Type: text/plain; charset="utf-8" +MIME-Version: 1.0 +Content-Transfer-Encoding: quoted-printable +To: Jani Nikula , "Tomi Ollila" , + notmuch@notmuchmail.org +From: Justus Winter <4winter@informatik.uni-hamburg.de> +In-Reply-To: <87k2nxh3pn.fsf@nikula.org> +Cc: tomi.ollila@iki.fi +References: <1439303834-27030-1-git-send-email-tomi.ollila@iki.fi> + <87k2nxh3pn.fsf@nikula.org> +Message-ID: <20160301164618.4486.11370@thinkbox.jade-hamburg.de> +User-Agent: alot/0.3.8.dev +Subject: Re: [PATCH] lib: have two definitions of NOTMUCH_DEPRECATED macro +Date: Tue, 01 Mar 2016 17:46:18 +0100 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 01 Mar 2016 16:46:24 -0000 + +Quoting Jani Nikula (2015-12-29 12:52:20) +> > __has_extension() replacement was modeled after __has_attribute() +> > definition in compat/function-attributes.h. Thanks Justus. + +Hum, I didn't even recall doing that. + +> > +/* clang provides this macro to test for support for language +> > + * extensions. If it isn't defined, this provides a compatibility +> > + * macro for other compilers. +> > + */ +> > +#ifndef __has_extension +> > +#define __has_extension(x) 0 +> > +#endif +> = + +> This file is included by the users of the library, and thus this +> definition leaks to our users. It might cause problems if the users have +> different expectations for handling ifndef __has_extension. I don't +> think we should define things outside of our namespace in notmuch.h. + +Indeed, even more so since the __ namespace is reserved. But that +should be easy to fix, right? Simply pick a less problematic name for +the new macro. + +I'd love to see this issue fixed. + +Cheers, +Justus