From: David Bremner <david@tethera.net>
Date: Sat, 10 Jan 2015 09:18:18 +0000 (+0100)
Subject: Re: [v2 1/3] thread.cc: Avoid empty thread names if possible.
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=7015dc74a7223c92229a61b02e180f3abfb1993c;p=notmuch-archives.git

Re: [v2 1/3] thread.cc: Avoid empty thread names if possible.
---

diff --git a/2f/730e00361086213baadef4366fd34592cbbcde b/2f/730e00361086213baadef4366fd34592cbbcde
new file mode 100644
index 000000000..034361f1a
--- /dev/null
+++ b/2f/730e00361086213baadef4366fd34592cbbcde
@@ -0,0 +1,72 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id D10AC431E64
+	for <notmuch@notmuchmail.org>; Sat, 10 Jan 2015 01:18:27 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 2.438
+X-Spam-Level: **
+X-Spam-Status: No, score=2.438 tagged_above=-999 required=5
+	tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id r8VFieAw9cmv for <notmuch@notmuchmail.org>;
+	Sat, 10 Jan 2015 01:18:24 -0800 (PST)
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
+	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id A6F34431E62
+	for <notmuch@notmuchmail.org>; Sat, 10 Jan 2015 01:18:24 -0800 (PST)
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
+	(envelope-from <david@tethera.net>)
+	id 1Y9sBc-0002VR-1I; Sat, 10 Jan 2015 05:18:24 -0400
+Received: (nullmailer pid 8029 invoked by uid 1000); Sat, 10 Jan 2015
+	09:18:18 -0000
+From: David Bremner <david@tethera.net>
+To: Jesse Rosenthal <jrosenthal@jhu.edu>, notmuch@notmuchmail.org
+Subject: Re: [v2 1/3] thread.cc: Avoid empty thread names if possible.
+In-Reply-To: <1414615905-22554-2-git-send-email-jrosenthal@jhu.edu>
+References: <1414615905-22554-1-git-send-email-jrosenthal@jhu.edu>
+	<1414615905-22554-2-git-send-email-jrosenthal@jhu.edu>
+User-Agent: Notmuch/0.19+10~g215de26 (http://notmuchmail.org) Emacs/24.4.1
+	(x86_64-pc-linux-gnu)
+Date: Sat, 10 Jan 2015 10:18:18 +0100
+Message-ID: <87k30vj8o5.fsf@maritornes.cs.unb.ca>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sat, 10 Jan 2015 09:18:28 -0000
+
+Jesse Rosenthal <jrosenthal@jhu.edu> writes:
+
+>  
+> +#define EMPTY_STRING(s) ((s)[0] == '\0') 
+> +
+
+Extra whitespace at end of line. If that's the only issue I can rebase
+it away, but maybe you want to enable the standard pre-commit hook?
+
+>  struct visible _notmuch_thread {
+>      notmuch_database_t *notmuch;
+>      char *thread_id;
+> @@ -330,11 +332,13 @@ _thread_set_subject_from_message (notmuch_thread_t *thread,
+>      } else {
+>  	cleaned_subject = talloc_strdup (thread, subject);
+>      }
+> +    
+Same here. 
+
+>