From: Tomi Ollila Date: Tue, 9 Apr 2013 12:12:34 +0000 (+0300) Subject: Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=6fe6bac452ef880c6427230d3f2a41da7773c346;p=notmuch-archives.git Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. --- diff --git a/de/928574d0f228924388d1fc57f647c584a23a50 b/de/928574d0f228924388d1fc57f647c584a23a50 new file mode 100644 index 000000000..85f172048 --- /dev/null +++ b/de/928574d0f228924388d1fc57f647c584a23a50 @@ -0,0 +1,110 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 233EE431FC0 + for ; Tue, 9 Apr 2013 05:12:37 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 0-TgwqJ48eYg for ; + Tue, 9 Apr 2013 05:12:36 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 6068E431FBD + for ; Tue, 9 Apr 2013 05:12:36 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 4B76C100093; + Tue, 9 Apr 2013 15:12:34 +0300 (EEST) +From: Tomi Ollila +To: David Bremner , Jed Brown , + Jani Nikula , Karl Fogel , + Daniel Bergey +Subject: Re: [PATCH] emacs: add missing paren to fix defun in + notmuch-address.el. +In-Reply-To: <87vc7vgbym.fsf@zancas.localnet> +References: <87wqsfik5l.fsf@floss.red-bean.com> + <87mwtah2hd.fsf@zancas.localnet> + <877gkeau42.fsf@floss.red-bean.com> + <8738v1jtzc.fsf@nikula.org> + <87k3odgutd.fsf@zancas.localnet> <87ip3wbj7g.fsf@mcs.anl.gov> + + <87vc7vgbym.fsf@zancas.localnet> +User-Agent: Notmuch/0.15.2+75~gd7fa7c4 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 09 Apr 2013 12:12:37 -0000 + +On Tue, Apr 09 2013, David Bremner wrote: + +> Tomi Ollila writes: +> +>> On Tue, Apr 09 2013, Jed Brown wrote: +>> +>>> David Bremner writes: +>>> +>>>> Squashed sounds good to me too. Sorry I'm too lazy/busy at the moment to +>>>> do it myself. +>>> +>>> I tested the attached and it's working as expected. Sent as an +>>> attachment to preserve author information. +>> +>> LGTM (this time tested, too). Also compared diffs by hand, change as announced. +>> comments in id:m26207wgyt.fsf@guru.guru-group.fi (amend!) apply. +> +> There seems to be a few warnings: +> +> In notmuch-bbdb/snarf-from: +> notmuch-address.el:116:26:Warning: reference to free variable +> `bbdb-get-addresses-headers' +> +> In notmuch-bbdb/snarf-to: +> notmuch-address.el:122:29:Warning: reference to free variable +> `bbdb-get-addresses-headers' +> +> In end of data: +> notmuch-address.el:143:1:Warning: the following functions are not known to be +> defined: bbdb-get-addresses, bbdb-update-records, notmuch-show-get-header +> +> Do we need a few defvars? + +For the above set, something like: + +(defvar bbdb-get-addresses-headers) + +(declare-function notmuch-show-get-header "notmuch-show" (header &optional props)) + +(declare-function bbdb-get-addresses "bbdb-com" + (only-first-address + uninteresting-senders + get-header-content-function + &rest get-header-content-function-args)) + +(declare-function bbdb-update-records "bbdb-com" (addrs auto-create-p offer-to-create)) + +> d + +Tomi