From: David Bremner <david@tethera.net>
Date: Tue, 16 Sep 2014 19:32:16 +0000 (+0200)
Subject: Re: [PATCH v2 06/10] cli: refactor insert
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=6fcef4f17f61e8da3bcaf5fc0fdd7e5555b9c2f8;p=notmuch-archives.git

Re: [PATCH v2 06/10] cli: refactor insert
---

diff --git a/85/bce7dbc84dc81e95120c4b0e6a9361ee477f32 b/85/bce7dbc84dc81e95120c4b0e6a9361ee477f32
new file mode 100644
index 000000000..bd2078e8f
--- /dev/null
+++ b/85/bce7dbc84dc81e95120c4b0e6a9361ee477f32
@@ -0,0 +1,76 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 1389F431FBC
+	for <notmuch@notmuchmail.org>; Tue, 16 Sep 2014 12:32:30 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id tOCJu05qOuZm for <notmuch@notmuchmail.org>;
+	Tue, 16 Sep 2014 12:32:26 -0700 (PDT)
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
+	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id 33EB8431FAE
+	for <notmuch@notmuchmail.org>; Tue, 16 Sep 2014 12:32:26 -0700 (PDT)
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
+	(envelope-from <david@tethera.net>)
+	id 1XTyUC-0006BA-GD; Tue, 16 Sep 2014 16:32:24 -0300
+Received: (nullmailer pid 7855 invoked by uid 1000); Tue, 16 Sep 2014
+	19:32:16 -0000
+From: David Bremner <david@tethera.net>
+To: Peter Wang <novalazy@gmail.com>
+Subject: Re: [PATCH v2 06/10] cli: refactor insert
+In-Reply-To: <20140706135728.GE1142@hili.localdomain>
+References: <1397653165-15620-1-git-send-email-novalazy@gmail.com>
+	<1397653165-15620-7-git-send-email-novalazy@gmail.com>
+	<87simgq702.fsf@maritornes.cs.unb.ca>
+	<20140706135728.GE1142@hili.localdomain>
+User-Agent: Notmuch/0.18.1+97~g56c48dc (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-pc-linux-gnu)
+Date: Tue, 16 Sep 2014 21:32:16 +0200
+Message-ID: <8738brpdj3.fsf@maritornes.cs.unb.ca>
+MIME-Version: 1.0
+Content-Type: text/plain
+Cc: notmuch@notmuchmail.org
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Tue, 16 Sep 2014 19:32:30 -0000
+
+Peter Wang <novalazy@gmail.com> writes:
+
+> On Sat, 05 Jul 2014 10:18:05 -0300, David Bremner <david@tethera.net> wrote:
+>> Peter Wang <novalazy@gmail.com> writes:
+>> 
+>> > -    cleanup_path = tmppath;
+>> > -
+>> > -    if (! copy_stdin (fdin, fdout))
+>> > -	goto FAIL;
+>> > +    if (! copy_stdin (fdin, fdout)) {
+>> > +	close (fdout);
+>> > +	unlink (tmppath);
+>> > +	return FALSE;
+>> > +    }
+
+I've now pushed up to patch 6 in the series, along with a couple of
+patches to deal with SONAME related breakage.
+
+I did end up squashing this patch in.
+
+d