From: Tomi Ollila Date: Wed, 21 May 2014 19:34:25 +0000 (+0300) Subject: Re: [PATCH 1/2] configure: add a fallback check for zlib X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=6f65be7c69baeaedbcbb129088d13017dfaf708c;p=notmuch-archives.git Re: [PATCH 1/2] configure: add a fallback check for zlib --- diff --git a/8a/77cd40dbde360a133cb96a9a3a14d533621822 b/8a/77cd40dbde360a133cb96a9a3a14d533621822 new file mode 100644 index 000000000..3bc4d88ec --- /dev/null +++ b/8a/77cd40dbde360a133cb96a9a3a14d533621822 @@ -0,0 +1,113 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 16662431FBC + for ; Wed, 21 May 2014 12:34:40 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id Tb8XHnW9gdn8 for ; + Wed, 21 May 2014 12:34:32 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 68EAB431FAE + for ; Wed, 21 May 2014 12:34:32 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 8E87C100090; + Wed, 21 May 2014 22:34:26 +0300 (EEST) +From: Tomi Ollila +To: Fraser Tweedale , notmuch@notmuchmail.org +Subject: Re: [PATCH 1/2] configure: add a fallback check for zlib +In-Reply-To: <20140521091304.GT62147@bacardi.hollandpark.frase.id.au> +References: <1399753646-3026-1-git-send-email-xico@atelo.org> + <536e965c9415e_300d7772fc9@nysa.notmuch> + + <536ea7d6a4c86_3c5a8eb3048b@nysa.notmuch> + <20140521091304.GT62147@bacardi.hollandpark.frase.id.au> +User-Agent: Notmuch/0.18+12~g9d41f94 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain; charset=utf-8 +Content-Transfer-Encoding: quoted-printable +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 21 May 2014 19:34:40 -0000 + +On Wed, May 21 2014, Fraser Tweedale wrote: + +> On Sat, May 10, 2014 at 05:27:34PM -0500, Felipe Contreras wrote: +>> Tomi Ollila wrote: +>> > On Sun, May 11 2014, Felipe Contreras wro= +te: +>> >=20 +>> > > X=C4=ABc=C3=B2 wrote: +>> > >> Since zlib is part of the base system, FreeBSD chose not to registe= +r it +>> > >> in pkg-config through zlib.pc. As a fallback test, configure will b= +uild +>> > >> and run a zlib version check and make sure the header and library +>> > >> versions are compatible. +>> > > +>> > > We could try to generate our on zlib.pc, this way the configure scri= +pt +>> > > would be cleaner. +>> >=20 +>> > But for that we'd need to figure out the version, and is there simpler +>> > robust way to do that some other way ? +>>=20 +>> I don't meant to change the code that is checking for the version in the +>> patch, you use the same code, but instead of have_zlib.c gen_zlib_pc.c, +>> or something. +>>=20 +> +> [please cc me in replies; I am not subscribed to the list] +> +> I think that the additional complexity outweighs the benefit of a +> somewhat cleaner build script. +> +> If the $vz1, $vz2, et al. are what's bothering you, perhaps we could +> push the complexity of version comparison into have_zlib.c and +> supply the (string) version number as an argument to the program. +> The have_zlib program could do the comparison and exit accordingly, +> and plain old "1.2.5.2" can take its place in the configure script +> once more. +> +> However, I don't see any problems with the patch as it is; I have +> tested it on FreeBSD 10.0 and it works. + +Did you notice=20 + +http://mid.gmane.org/1399864172-28227-1-git-send-email-felipe.contreras@gma= +il.com + +:D + +> +> Regards, +> +> Fraser +> +>> --=20 +>> Felipe Contreras + +Tomi