From: Mark Walters Date: Sat, 12 Apr 2014 08:40:33 +0000 (+0100) Subject: [PATCH 2/2] NEWS: document possible breakage from saved-search format change X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=6e20ca1bf3a894bb85ebd03ac8cac62b2f6eda70;p=notmuch-archives.git [PATCH 2/2] NEWS: document possible breakage from saved-search format change --- diff --git a/71/16b18e863dc8cd40a0a092453d1d516305c2ed b/71/16b18e863dc8cd40a0a092453d1d516305c2ed new file mode 100644 index 000000000..898b47b88 --- /dev/null +++ b/71/16b18e863dc8cd40a0a092453d1d516305c2ed @@ -0,0 +1,104 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 02DC8431FC4 + for ; Sat, 12 Apr 2014 01:40:48 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0.201 +X-Spam-Level: +X-Spam-Status: No, score=0.201 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001, + RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id qS-tThG12DY7 for ; + Sat, 12 Apr 2014 01:40:43 -0700 (PDT) +Received: from mail-we0-f174.google.com (mail-we0-f174.google.com + [74.125.82.174]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 4A268431FBC + for ; Sat, 12 Apr 2014 01:40:43 -0700 (PDT) +Received: by mail-we0-f174.google.com with SMTP id t60so6169083wes.5 + for ; Sat, 12 Apr 2014 01:40:40 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:cc:subject:date:message-id:in-reply-to:references; + bh=D+JkbMem8CbF/CRAM6NMKgmRDbzgy/6xIGoXVJQWFsU=; + b=V0dcChKcQEPnQCeXApRsgwDG9SWZNXwcZqcuYPvpH8vCyfYSeC2ImPWtZjkEl2OLjR + 19+6oQN0b3RJ2KBDV9wnUgXACLYaGpJ0alwd0+AahFcsl7E8FQywSq5LmPSIU1xjJVxR + R2UMFSll4rlg5vlJ4Mf9ZwerwD6N36yU5Ism2CnJS3O3NalI2KyGZot5cxSD9ew/4VXj + RImx6BhhrQRvqQ4wElI4mrmwCWCONzt80+Kmmf7wKCnfNowNg80OqutWFzLx1UnjOR5o + qPosSFeV2C8oiQSYzZkbLx1nUHXufYlFR5qv1hUDycQMJJEIcQxXVSxVvd/yuTRaDL8J + dLCA== +X-Received: by 10.180.78.200 with SMTP id d8mr1742385wix.34.1397292040885; + Sat, 12 Apr 2014 01:40:40 -0700 (PDT) +Received: from localhost (5751dfa2.skybroadband.com. [87.81.223.162]) + by mx.google.com with ESMTPSA id p8sm9382502wia.3.2014.04.12.01.40.39 + for + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Sat, 12 Apr 2014 01:40:40 -0700 (PDT) +From: Mark Walters +To: notmuch@notmuchmail.org +Subject: [PATCH 2/2] NEWS: document possible breakage from saved-search format + change +Date: Sat, 12 Apr 2014 09:40:33 +0100 +Message-Id: <1397292033-26502-2-git-send-email-markwalters1009@gmail.com> +X-Mailer: git-send-email 1.7.10.4 +In-Reply-To: <1397292033-26502-1-git-send-email-markwalters1009@gmail.com> +References: <1397292033-26502-1-git-send-email-markwalters1009@gmail.com> +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 12 Apr 2014 08:40:49 -0000 + +If the user has unsorted or alphabetically sorted saved-searches these +should continue to work. If they have some custom lisp sort function +then it will need updating to work with the new saved-sort +format. Document this, and how the updating should be done. + +Also roll in the fix for the markdown in the first part of the NEWS: +`just work' to *just work* as suggested by Tomi. +--- + NEWS | 8 ++++++-- + 1 file changed, 6 insertions(+), 2 deletions(-) + +diff --git a/NEWS b/NEWS +index 8aa4182..106a31f 100644 +--- a/NEWS ++++ b/NEWS +@@ -24,7 +24,7 @@ Changed format for saved searches. + shows. + + The variable is fully customizable and any configuration done +- through customize should `just work', with the additional options ++ through customize should *just work*, with the additional options + mentioned above. For manual customization see the documentation for + `notmuch-saved-searches`. + +@@ -32,7 +32,11 @@ Changed format for saved searches. + previous versions of notmuch-emacs (even search will not work); to + fix remove the customization for notmuch-saved-searches. + +-Bug fix for saved searches with newlines in them. ++ If you have a custom saved search sort function (not unsorted or ++ alphabetical) then the sort function will need to be ++ modified. Replacing (car saved-search) by (notmuch-saved-search-get ++ saved-search :name) and (cdr saved-search) by ++ (notmuch-saved-search-get saved-search :query) should be sufficient. + + Split lines confuse `notmuch count --batch`, so we remove embedded + newlines before calling notmuch count. +-- +1.7.10.4 +