From: Zac Medico <zmedico@gentoo.org>
Date: Sun, 24 Jan 2010 17:10:52 +0000 (-0000)
Subject: Add a warning for built_with_use. Thanks to Petteri Räty <betelgeuse@g.o> for
X-Git-Tag: v2.2_rc62~11
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=6da3146e1a4dd3d8f6cda6d4fa3c6aaec25f4751;p=portage.git

Add a warning for built_with_use. Thanks to Petteri Räty <betelgeuse@g.o> for
this patch.

svn path=/main/trunk/; revision=15209
---

diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py
index 4e83e6653..36e074c9f 100644
--- a/pym/repoman/checks.py
+++ b/pym/repoman/checks.py
@@ -432,6 +432,12 @@ class SrcUnpackPatches(PhaseCheck):
 				return ("'%s'" % m.group(1)) + \
 					" call should be moved to src_prepare from line: %d"
 
+class BuiltWithUse(LineCheck):
+	repoman_check_name = 'ebuild.minorsyn'
+	ignore_line = re.compile(r'^\s*#')
+	re = re.compile('^.*built_with_use')
+	error = errors.BUILT_WITH_USE
+
 # EAPI-4 checks
 class Eapi4IncompatibleFuncs(LineCheck):
 	repoman_check_name = 'EAPI.incompatible'
@@ -467,7 +473,6 @@ class Eapi4GoneVars(LineCheck):
 			return ("variable '$%s'" % m.group(1)) + \
 				" is gone in EAPI=4 on line: %d"
 
-
 _constant_checks = tuple((c() for c in (
 	EbuildHeader, EbuildWhitespace, EbuildBlankLine, EbuildQuote,
 	EbuildAssignment, EbuildUselessDodoc,
@@ -476,7 +481,7 @@ _constant_checks = tuple((c() for c in (
 	IUseUndefined, InheritAutotools,
 	EMakeParallelDisabled, EMakeParallelDisabledViaMAKEOPTS, NoAsNeeded,
 	DeprecatedBindnowFlags, SrcUnpackPatches, WantAutoDefaultValue,
-	SrcCompileEconf, Eapi4IncompatibleFuncs, Eapi4GoneVars)))
+	SrcCompileEconf, Eapi4IncompatibleFuncs, Eapi4GoneVars, BuiltWithUse)))
 
 _here_doc_re = re.compile(r'.*\s<<[-]?(\w+)$')
 
diff --git a/pym/repoman/errors.py b/pym/repoman/errors.py
index b62af12b3..cd1d7e3d7 100644
--- a/pym/repoman/errors.py
+++ b/pym/repoman/errors.py
@@ -18,3 +18,4 @@ EMAKE_PARALLEL_DISABLED_VIA_MAKEOPTS = 'Upstream parallel compilation bug (MAKEO
 DEPRECATED_BINDNOW_FLAGS = 'Deprecated bindnow-flags call on line: %d'
 EAPI_DEFINED_AFTER_INHERIT = 'EAPI defined after inherit on line: %d'
 NO_AS_NEEDED = 'Upstream asneeded linking bug (no-as-needed on line: %d)'
+BUILT_WITH_USE = 'built_with_use on line: %d'