From: Tomi Ollila Date: Wed, 1 Jan 2014 14:46:48 +0000 (+0200) Subject: Re: [PATCH] test: tree: pick remnants removed X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=6cd8eee5402ee59d6aa9a8809477de1364348ec4;p=notmuch-archives.git Re: [PATCH] test: tree: pick remnants removed --- diff --git a/cc/6df5ad082e216814aef3aee98bb13c92e1a39d b/cc/6df5ad082e216814aef3aee98bb13c92e1a39d new file mode 100644 index 000000000..d40df80c5 --- /dev/null +++ b/cc/6df5ad082e216814aef3aee98bb13c92e1a39d @@ -0,0 +1,196 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 41958431FC0 + for ; Wed, 1 Jan 2014 06:46:59 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id yHBZztLek+KH for ; + Wed, 1 Jan 2014 06:46:54 -0800 (PST) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 8030D431FAF + for ; Wed, 1 Jan 2014 06:46:54 -0800 (PST) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 3E7B81000B2; + Wed, 1 Jan 2014 16:46:48 +0200 (EET) +From: Tomi Ollila +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH] test: tree: pick remnants removed +In-Reply-To: <1387061912-24349-1-git-send-email-markwalters1009@gmail.com> +References: <1387061912-24349-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.17+13~gdfcf116 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 01 Jan 2014 14:46:59 -0000 + +On Sun, Dec 15 2013, Mark Walters wrote: + +> Some no longer needed traces of pick remain in the emacs-tree +> test. Remove these. +> --- +> When playing with tree read/unread things I found these remnants in +> the emacs-tree test. They do no harm but should be removed. Sorry I +> missed these in the pick/tree merge. + +LGTM. tests pass. + +> +> Best wishes +> +> Mark + +Tomi + +> +> +> +> test/emacs-tree | 38 +++++++++++--------------------------- +> 1 files changed, 11 insertions(+), 27 deletions(-) +> +> diff --git a/test/emacs-tree b/test/emacs-tree +> index 4bdfddd..8e9f37c 100755 +> --- a/test/emacs-tree +> +++ b/test/emacs-tree +> @@ -8,16 +8,14 @@ EXPECTED=$TEST_DIRECTORY/tree.expected-output +> add_email_corpus +> +> test_begin_subtest "Basic notmuch-tree view in emacs" +> -test_emacs '(add-to-list (quote load-path) "'$PICK_DIR'") +> - (notmuch-tree "tag:inbox") +> +test_emacs '(notmuch-tree "tag:inbox") +> (notmuch-test-wait) +> (test-output) +> (delete-other-windows)' +> test_expect_equal_file OUTPUT $EXPECTED/notmuch-tree-tag-inbox +> +> test_begin_subtest "Refreshed notmuch-tree view in emacs" +> -test_emacs '(add-to-list (quote load-path) "'$PICK_DIR'") +> - (notmuch-tree "tag:inbox") +> +test_emacs '(notmuch-tree "tag:inbox") +> (notmuch-test-wait) +> (notmuch-tree-refresh-view) +> (notmuch-test-wait) +> @@ -30,8 +28,7 @@ test_expect_equal_file OUTPUT $EXPECTED/notmuch-tree-tag-inbox +> # correctly. +> +> test_begin_subtest "Tag message in notmuch tree view (display)" +> -test_emacs '(add-to-list (quote load-path) "'$PICK_DIR'") +> - (notmuch-tree "tag:inbox") +> +test_emacs '(notmuch-tree "tag:inbox") +> (notmuch-test-wait) +> (forward-line) +> (notmuch-tree-tag (list "+test_tag")) +> @@ -44,8 +41,7 @@ output=$(notmuch search --output=messages 'tag:test_tag') +> test_expect_equal "$output" "id:877h1wv7mg.fsf@inf-8657.int-evry.fr" +> +> test_begin_subtest "Untag message in notmuch tree view" +> -test_emacs '(add-to-list (quote load-path) "'$PICK_DIR'") +> - (notmuch-tree "tag:inbox") +> +test_emacs '(notmuch-tree "tag:inbox") +> (notmuch-test-wait) +> (forward-line) +> (notmuch-tree-tag (list "-test_tag")) +> @@ -58,8 +54,7 @@ output=$(notmuch search --output=messages 'tag:test_tag') +> test_expect_equal "$output" "" +> +> test_begin_subtest "Tag thread in notmuch tree view" +> -test_emacs '(add-to-list (quote load-path) "'$PICK_DIR'") +> - (notmuch-tree "tag:inbox") +> +test_emacs '(notmuch-tree "tag:inbox") +> (notmuch-test-wait) +> ;; move to a sizable thread +> (forward-line 26) +> @@ -80,8 +75,7 @@ id:87iqd9rn3l.fsf@vertex.dottedmag +> id:20091117190054.GU3165@dottiness.seas.harvard.edu" +> +> test_begin_subtest "Untag thread in notmuch tree view" +> -test_emacs '(add-to-list (quote load-path) "'$PICK_DIR'") +> - (notmuch-tree "tag:inbox") +> +test_emacs '(notmuch-tree "tag:inbox") +> (notmuch-test-wait) +> ;; move to the same sizable thread as above +> (forward-line 26) +> @@ -147,26 +141,20 @@ cp OUTPUT /tmp/mjwout +> test_expect_equal_file OUTPUT $EXPECTED/notmuch-tree-show-window +> +> test_begin_subtest "Stash id" +> -output=$(test_emacs '(add-to-list (quote load-path) "'$PICK_DIR'") +> - (require (quote notmuch-tree)) +> - (notmuch-tree "id:1258498485-sup-142@elly") +> +output=$(test_emacs '(notmuch-tree "id:1258498485-sup-142@elly") +> (notmuch-test-wait) +> (notmuch-show-stash-message-id)') +> test_expect_equal "$output" "\"Stashed: id:1258498485-sup-142@elly\"" +> +> test_begin_subtest "Move to next matching message" +> -output=$(test_emacs '(add-to-list (quote load-path) "'$PICK_DIR'") +> - (require (quote notmuch-tree)) +> - (notmuch-tree "from:cworth") +> +output=$(test_emacs '(notmuch-tree "from:cworth") +> (notmuch-test-wait) +> (notmuch-tree-next-matching-message) +> (notmuch-show-stash-message-id)') +> test_expect_equal "$output" "\"Stashed: id:878we4qdqf.fsf@yoom.home.cworth.org\"" +> +> test_begin_subtest "Move to next thread" +> -output=$(test_emacs '(add-to-list (quote load-path) "'$PICK_DIR'") +> - (require (quote notmuch-tree)) +> - (notmuch-tree "tag:inbox") +> +output=$(test_emacs '(notmuch-tree "tag:inbox") +> (notmuch-test-wait) +> (forward-line 26) +> (notmuch-tree-next-thread) +> @@ -174,9 +162,7 @@ output=$(test_emacs '(add-to-list (quote load-path) "'$PICK_DIR'") +> test_expect_equal "$output" "\"Stashed: id:1258471718-6781-1-git-send-email-dottedmag@dottedmag.net\"" +> +> test_begin_subtest "Move to previous thread" +> -output=$(test_emacs '(add-to-list (quote load-path) "'$PICK_DIR'") +> - (require (quote notmuch-tree)) +> - (notmuch-tree "tag:inbox") +> +output=$(test_emacs '(notmuch-tree "tag:inbox") +> (notmuch-test-wait) +> (forward-line 26) +> (notmuch-tree-prev-thread) +> @@ -184,9 +170,7 @@ output=$(test_emacs '(add-to-list (quote load-path) "'$PICK_DIR'") +> test_expect_equal "$output" "\"Stashed: id:20091117190054.GU3165@dottiness.seas.harvard.edu\"" +> +> test_begin_subtest "Move to previous previous thread" +> -output=$(test_emacs '(add-to-list (quote load-path) "'$PICK_DIR'") +> - (require (quote notmuch-tree)) +> - (notmuch-tree "tag:inbox") +> +output=$(test_emacs '(notmuch-tree "tag:inbox") +> (notmuch-test-wait) +> (forward-line 26) +> (notmuch-tree-prev-thread) +> -- +> 1.7.9.1 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch