From: Marten Veldthuis Date: Fri, 27 Nov 2009 22:06:40 +0000 (+0100) Subject: Re: [notmuch] [PATCH] Add tests to configure script to detect strndup and getline X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=6cb766c65b9b8dcd9cac3ff7d6b75406b1439f7a;p=notmuch-archives.git Re: [notmuch] [PATCH] Add tests to configure script to detect strndup and getline --- diff --git a/ad/24b979d40c3249c5a0bfad7465cbbf83326e46 b/ad/24b979d40c3249c5a0bfad7465cbbf83326e46 new file mode 100644 index 000000000..0a918c77f --- /dev/null +++ b/ad/24b979d40c3249c5a0bfad7465cbbf83326e46 @@ -0,0 +1,76 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 44186431FBC + for ; Fri, 27 Nov 2009 14:06:49 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id HfR+TuOWI7xK for ; + Fri, 27 Nov 2009 14:06:48 -0800 (PST) +Received: from mout.perfora.net (mout.perfora.net [74.208.4.195]) + by olra.theworths.org (Postfix) with ESMTP id 67D74431FAE + for ; Fri, 27 Nov 2009 14:06:48 -0800 (PST) +Received: from smtp04.online.nl (smtp04.online.nl [194.134.41.34]) + by mx.perfora.net (node=mxus2) with ESMTP (Nemesis) + id 0LpcRq-1NkkDZ1aje-00fY3H for notmuch@notmuchmail.org; + Fri, 27 Nov 2009 17:06:47 -0500 +Received: from smtp04.online.nl (localhost [127.0.0.1]) + by smtp04.online.nl (Postfix) with ESMTP id AA1BDE098 + for ; Fri, 27 Nov 2009 23:06:41 +0100 (CET) +Received: from home.veldthuis.com (s55919504.adsl.wanadoo.nl [85.145.149.4]) + by smtp04.online.nl (Postfix) with ESMTP + for ; Fri, 27 Nov 2009 23:06:41 +0100 (CET) +Received: by home.veldthuis.com (Postfix, from userid 501) + id 999542DA664; Fri, 27 Nov 2009 23:06:40 +0100 (CET) +Date: Fri, 27 Nov 2009 23:06:40 +0100 +From: Marten Veldthuis +To: notmuch@notmuchmail.org +Message-ID: <20091127220640.GA17750@gopher.local> +Mail-Followup-To: notmuch@notmuchmail.org +References: <1258983810-27522-2-git-send-email-jeff@ocjtech.us> + <1259000055-15068-1-git-send-email-jeff@ocjtech.us> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii; format=flowed +Content-Disposition: inline +In-Reply-To: <1259000055-15068-1-git-send-email-jeff@ocjtech.us> +User-Agent: Mutt/1.5.20 (2009-06-14) +X-Online-Scanned: by Cloudmark authority (on smtp04.online.nl) +Subject: Re: [notmuch] [PATCH] Add tests to configure script to detect + strndup and getline +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.12 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 27 Nov 2009 22:06:49 -0000 + +On Mon, Nov 23, 2009 at 12:14:15PM -0600, Jeffrey C. Ollie wrote: +> cat > Makefile.config < prefix = /usr/local +> bash_completion_dir = /etc/bash_completion.d +>-CFLAGS += ${have_valgrind} +>+CFLAGS += ${have_valgrind} ${strndup} ${getline} +> EOF + +This doesn't seem to do much for me, they don't seem to end up in the args +passed to g++. I'm no Makefile wizard, so I got notmuch finally compiling by +simply copy/pasting the ${strndup} and ${getline} from Makefile.config to +Makefile: + +# Now smash together user's values with our extra values +override CFLAGS += $(WARN_FLAGS) $(extra_cflags) -Dstrndup=_notmuch_strndup +-Dgetline=_notmuch_getline +override CXXFLAGS += $(WARN_FLAGS) $(extra_cflags) $(extra_cxxflags) +-Dstrndup=_notmuch_strndup -Dgetline=_notmuch_getline + +-- +- Marten