From: David Bremner Date: Mon, 7 Mar 2016 12:01:25 +0000 (+2000) Subject: Re: talloc_abort in notmuch_thread_get_tags () when db has been modified X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=6c211161bc7840d6299328cd7e64eaed1378264e;p=notmuch-archives.git Re: talloc_abort in notmuch_thread_get_tags () when db has been modified --- diff --git a/6f/2a570c5dd6516498f66a04137c38305a020ae6 b/6f/2a570c5dd6516498f66a04137c38305a020ae6 new file mode 100644 index 000000000..1b2319c09 --- /dev/null +++ b/6f/2a570c5dd6516498f66a04137c38305a020ae6 @@ -0,0 +1,66 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 90EF96DE028A + for ; Mon, 7 Mar 2016 04:01:37 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.034 +X-Spam-Level: +X-Spam-Status: No, score=-0.034 tagged_above=-999 required=5 + tests=[AWL=-0.023, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id i-hE1bqpgyYA for ; + Mon, 7 Mar 2016 04:01:31 -0800 (PST) +Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) + by arlo.cworth.org (Postfix) with ESMTPS id 2471B6DE0244 + for ; Mon, 7 Mar 2016 04:01:30 -0800 (PST) +Received: from remotemail by fethera.tethera.net with local (Exim 4.84) + (envelope-from ) + id 1actrQ-0001M5-Tz; Mon, 07 Mar 2016 07:02:04 -0500 +Received: (nullmailer pid 14311 invoked by uid 1000); + Mon, 07 Mar 2016 12:01:25 -0000 +From: David Bremner +To: Gaute Hope , notmuch@notmuchmail.org +Subject: Re: talloc_abort in notmuch_thread_get_tags () when db has been + modified +In-Reply-To: <1457341792-astroid-0-2wtydh6y1q-15951@strange> +References: <1453121100-astroid-2-c62fwcrm91-18877@strange> + <1457341792-astroid-0-2wtydh6y1q-15951@strange> +User-Agent: Notmuch/0.21+26~g9404723 (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Mon, 07 Mar 2016 08:01:25 -0400 +Message-ID: <87r3fmts2y.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 07 Mar 2016 12:01:37 -0000 + +Gaute Hope writes: + +> as far as I can see, there is _no_ way to catch this error without +> completely crashing the application. I would have to isolate this code +> in a separate process or trap SIGABRT (which is certainly messy). + +I'm not sure what you expect libnotmuch to do here. There's a fatal +"should not happen" error in the memory allocator; it isn't really the +sort of thing one can recover from. It's also not in code we control. + +Of course _why_ this error is happening could still be notmuch's +fault. Can you reproduce the problem under valgrind? + +d