From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Tue, 21 May 2013 14:17:37 +0000 (+0300)
Subject: Re: [PATCH 2/2] ruby: fix missing symbol UINT2FIX()
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=6b936454f7c6b0c89bf2cc9baa371c7141030751;p=notmuch-archives.git

Re: [PATCH 2/2] ruby: fix missing symbol UINT2FIX()
---

diff --git a/24/badaff30fa889a474f2a9e3628dfffb58cbd2c b/24/badaff30fa889a474f2a9e3628dfffb58cbd2c
new file mode 100644
index 000000000..0747e6b8b
--- /dev/null
+++ b/24/badaff30fa889a474f2a9e3628dfffb58cbd2c
@@ -0,0 +1,88 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 8B724431FC7
+	for <notmuch@notmuchmail.org>; Tue, 21 May 2013 07:17:42 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id g-H4i88JfAMy for <notmuch@notmuchmail.org>;
+	Tue, 21 May 2013 07:17:38 -0700 (PDT)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id 4C6DA431FB6
+	for <notmuch@notmuchmail.org>; Tue, 21 May 2013 07:17:38 -0700 (PDT)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id A50D21002C3;
+	Tue, 21 May 2013 17:17:37 +0300 (EEST)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: Felipe Contreras <felipe.contreras@gmail.com>, notmuch@notmuchmail.org
+Subject: Re: [PATCH 2/2] ruby: fix missing symbol UINT2FIX()
+In-Reply-To: <1369052664-17869-3-git-send-email-felipe.contreras@gmail.com>
+References: <1369052664-17869-1-git-send-email-felipe.contreras@gmail.com>
+	<1369052664-17869-3-git-send-email-felipe.contreras@gmail.com>
+User-Agent: Notmuch/0.15.2+99~g7e455bc (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Tue, 21 May 2013 17:17:37 +0300
+Message-ID: <m2vc6c4dtq.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+Cc: Ali Polatel <alip@exherbo.org>
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Tue, 21 May 2013 14:17:42 -0000
+
+On Mon, May 20 2013, Felipe Contreras <felipe.contreras@gmail.com> wrote:
+
+> It has never existed in Ruby (maybe JRuby). Fortunately the symbols are
+> loaded lazily, so nobody would notice unless they try
+> 'query::count_messages'.
+>
+> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
+
+This patch could be pushed on it's own, but someone (like Ali) could
+comment on the change as searches on both UINT2FIX() & UINT2NUM()
+provides (IMH) insatisfactory results...
+
+Tomi
+
+> ---
+>  bindings/ruby/query.c | 2 +-
+>  1 file changed, 1 insertion(+), 1 deletion(-)
+>
+> diff --git a/bindings/ruby/query.c b/bindings/ruby/query.c
+> index e5ba1b7..1658ede 100644
+> --- a/bindings/ruby/query.c
+> +++ b/bindings/ruby/query.c
+> @@ -180,5 +180,5 @@ notmuch_rb_query_count_messages (VALUE self)
+>       * (function may return 0 after printing a message)
+>       * Thus there is nothing we can do here...
+>       */
+> -    return UINT2FIX(notmuch_query_count_messages(query));
+> +    return UINT2NUM(notmuch_query_count_messages(query));
+>  }
+> -- 
+> 1.8.3.rc3.286.g3d43083
+>
+> _______________________________________________
+> notmuch mailing list
+> notmuch@notmuchmail.org
+> http://notmuchmail.org/mailman/listinfo/notmuch