From: Mark Walters Date: Sat, 5 Mar 2016 11:00:00 +0000 (+0000) Subject: Re: use font-face instead of explicit colouring X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=6a2446678c770bf77bc26040eb2c2093d4ba5c2d;p=notmuch-archives.git Re: use font-face instead of explicit colouring --- diff --git a/6b/8215af177ee052c906d56a98b54957fe2603a7 b/6b/8215af177ee052c906d56a98b54957fe2603a7 new file mode 100644 index 000000000..191a44ad4 --- /dev/null +++ b/6b/8215af177ee052c906d56a98b54957fe2603a7 @@ -0,0 +1,133 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id BB3AC6DE11EC + for ; Sat, 5 Mar 2016 03:00:06 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.295 +X-Spam-Level: +X-Spam-Status: No, score=-0.295 tagged_above=-999 required=5 tests=[AWL=0.275, + DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, + RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id m_ZKWMIz6IiQ for ; + Sat, 5 Mar 2016 03:00:04 -0800 (PST) +Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com + [74.125.82.43]) by arlo.cworth.org (Postfix) with ESMTPS id A84236DE1003 for + ; Sat, 5 Mar 2016 03:00:03 -0800 (PST) +Received: by mail-wm0-f43.google.com with SMTP id l68so23395927wml.0 + for ; Sat, 05 Mar 2016 03:00:03 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:subject:in-reply-to:references:user-agent:date:message-id + :mime-version; bh=G+3WKg3RbQVvALmO/RqUDmEznABjm9Prx9xiy1aoO+M=; + b=rQqg7d5YsIP1dN9SLWPQIy5wJmFTwPMPCKylKzxTmfobrShwmDIKIuNGp+WJHFkj2i + sGVXX9roSWn19hZOXi2iGW5PPgdsx8LycQShziJK3BC8ZKuXaPi5OMqO/zdGzQ1ZtNLx + VlJYUX1DgmN0EEWojQ4MRbfEqG/DRLKjsEg93EICfgxEO/GYI/cB3vsVjxfaDUfF6ifO + tHRVchBu43HXzkmeS6fhQY/mTiC8uNiN9MPf6KjrjDUxYI2iWQTAWhlWKXOlnbjo+FPV + r0dfvDkDwiJUTpJ2vRLIdwFx1x1qMKZI1HUlyE8QtUPtNc4SsimB6xqBNwxli2djho13 + i6YQ== +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:subject:in-reply-to:references + :user-agent:date:message-id:mime-version; + bh=G+3WKg3RbQVvALmO/RqUDmEznABjm9Prx9xiy1aoO+M=; + b=SdE610WxdE+XCw3AxfOdBfSwbMgntR183fhR7cxJWV6GhFAJm54QYHRiuDOZ3LZtJp + QDyqBN7RTg9d3oHPZn3qi8FZ4LohdApcoaBD1aOs0Vs6DMSBkdjfDp4QJIXBRfF+GFT+ + 15sxUgjPc9VXQddIt4UP5rXfa7JCP3ioqRqaORKYhHDzHo8RFAQrTgGFTWiAYG6spTpx + FWFjeO4AMdYeeFff19qMBaCW186Lh7ezl7Kb77OZMAmndOku9uv/oUMn+RtRZwE5egi+ + Nz+WWfCthCSrB04F787Bs7wT556wMB+IFBTgqvAEEnBDUg5GLlKesWiNzncfKwmTVhXv + 93pQ== +X-Gm-Message-State: + AD7BkJLrMazz89eWNcj5la7nScB4RgFvkgN9z/gdjF6JVG611lfW7mnFBusWP8IJM/mGEg== +X-Received: by 10.28.111.135 with SMTP id c7mr3566771wmi.46.1457175601930; + Sat, 05 Mar 2016 03:00:01 -0800 (PST) +Received: from localhost (5751dfa2.skybroadband.com. [87.81.223.162]) + by smtp.gmail.com with ESMTPSA id 198sm3332325wml.22.2016.03.05.03.00.00 + (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Sat, 05 Mar 2016 03:00:01 -0800 (PST) +From: Mark Walters +To: Sam Halliday , notmuch@notmuchmail.org +Subject: Re: use font-face instead of explicit colouring +In-Reply-To: <87k2lhmecn.fsf@gmail.com> +References: <87mvqdmer2.fsf@gmail.com> <87k2lhmecn.fsf@gmail.com> +User-Agent: Notmuch/0.18.1+485~gca076ce (http://notmuchmail.org) Emacs/24.4.1 + (x86_64-pc-linux-gnu) +Date: Sat, 05 Mar 2016 11:00:00 +0000 +Message-ID: <87h9glb367.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 05 Mar 2016 11:00:06 -0000 + + +Hi + +On Sat, 05 Mar 2016, Sam Halliday wrote: +> I should say that I am aware of the workaround, e.g. +> +> (setq +> notmuch-search-line-faces '(("unread" :weight bold) +> ("flagged" :inherit 'font-lock-string-face))) +> +> but this must be applied per-user. If you removed this defcustom and had +> unread/flagged/other faces, then themes (such as darcula) would be able +> to provide sensible defaults out of the box. + +I am not sure I see how this would work without cluttering up the +customize options significantly. The notmuch-search-line-faces allows +selecting the face based on any tag (so for example I use different +colours for emails tagged "work", and tagged "waiting"). We could have +additional notmuch-search-line-unread-face which could then be used in +the above -- but now the user has two places to customize the same thing. + +How do you see this working? + +(We probably could make the default depend on light or dark theme to make +the default more usable.) + +Best wishes + +Mark + +> +> Sam Halliday writes: +> +>> [ text/plain ] +>> Hi, +>> +>> I use a dark theme and many of the colour choices of notmuch collide +>> with my theme. However, notmuch is explicitly adding information such as +>> "blue foreground" instead of using faces that I can customise. +>> +>> Could you please consider using faces instead of explicit colours? +>> +>> [ text/plain ] +>> +>> -- +>> Best regards, +>> Sam +>> [ signature.asc: application/pgp-signature ] +> +> -- +> Best regards, +> Sam +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> https://notmuchmail.org/mailman/listinfo/notmuch