From: David Bremner <david@tethera.net>
Date: Sun, 14 Aug 2016 00:41:35 +0000 (+0900)
Subject: Re: [PATCH v4 13/16] add indexopts to notmuch python bindings.
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=69a01bc94ef7420b81ef1977361539ef030e2535;p=notmuch-archives.git

Re: [PATCH v4 13/16] add indexopts to notmuch python bindings.
---

diff --git a/02/4b7a43dde234735cad06cbda58e08ffda47fef b/02/4b7a43dde234735cad06cbda58e08ffda47fef
new file mode 100644
index 000000000..a43c84f67
--- /dev/null
+++ b/02/4b7a43dde234735cad06cbda58e08ffda47fef
@@ -0,0 +1,66 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id 58C666DE51D6
+ for <notmuch@notmuchmail.org>; Sat, 13 Aug 2016 18:08:55 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: -0.007
+X-Spam-Level: 
+X-Spam-Status: No, score=-0.007 tagged_above=-999 required=5 tests=[AWL=0.004,
+  SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id tbd99g4NOJ_m for <notmuch@notmuchmail.org>;
+ Sat, 13 Aug 2016 18:08:47 -0700 (PDT)
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
+ by arlo.cworth.org (Postfix) with ESMTPS id 702856DE4983
+ for <notmuch@notmuchmail.org>; Sat, 13 Aug 2016 17:41:47 -0700 (PDT)
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2)
+ (envelope-from <david@tethera.net>)
+ id 1bYjUu-0005IC-Uw; Sat, 13 Aug 2016 20:41:52 -0400
+Received: (nullmailer pid 32422 invoked by uid 1000);
+ Sun, 14 Aug 2016 00:41:35 -0000
+From: David Bremner <david@tethera.net>
+To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,
+ Notmuch Mail <notmuch@notmuchmail.org>
+Subject: Re: [PATCH v4 13/16] add indexopts to notmuch python bindings.
+In-Reply-To: <1467970047-8013-14-git-send-email-dkg@fifthhorseman.net>
+References: <1467970047-8013-1-git-send-email-dkg@fifthhorseman.net>
+ <1467970047-8013-14-git-send-email-dkg@fifthhorseman.net>
+User-Agent: Notmuch/0.22.1+61~g2ce0f13 (https://notmuchmail.org) Emacs/24.5.1
+ (x86_64-pc-linux-gnu)
+Date: Sun, 14 Aug 2016 09:41:35 +0900
+Message-ID: <87vaz441xc.fsf@maritornes.cs.unb.ca>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.20
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sun, 14 Aug 2016 01:08:55 -0000
+
+Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
+>  
+> +        :param indexopts: a nomtuch.Indexopts object indicating custom
+> +            options desired for indexing.
+> +
+
+typo
+
+>                        be added.
+> +
+spurious whitespace change?
+
+otherwise the patch looks fine.
+
+d