From: Austin Clements Date: Fri, 4 Apr 2014 21:26:31 +0000 (+2000) Subject: Re: [PATCH v5 0/2] lib: drop mbox support, replace header parser with gmime X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=69440b70f1f26bd9585dcdce5f9109f4f1e765d4;p=notmuch-archives.git Re: [PATCH v5 0/2] lib: drop mbox support, replace header parser with gmime --- diff --git a/f8/c2af3f7d5c89b91f1246be879e0cd12def97d6 b/f8/c2af3f7d5c89b91f1246be879e0cd12def97d6 new file mode 100644 index 000000000..66d7c6ef5 --- /dev/null +++ b/f8/c2af3f7d5c89b91f1246be879e0cd12def97d6 @@ -0,0 +1,104 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 8B809431FBF + for ; Fri, 4 Apr 2014 14:26:43 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id jhRy1L4yOGpx for ; + Fri, 4 Apr 2014 14:26:36 -0700 (PDT) +Received: from dmz-mailsec-scanner-2.mit.edu (dmz-mailsec-scanner-2.mit.edu + [18.9.25.13]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 4EE72431FAF + for ; Fri, 4 Apr 2014 14:26:36 -0700 (PDT) +X-AuditID: 1209190d-f79776d000000ce9-19-533f238bf7fe +Received: from mailhub-auth-1.mit.edu ( [18.9.21.35]) + (using TLS with cipher AES256-SHA (256/256 bits)) + (Client did not present a certificate) + by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP + id 53.D4.03305.B832F335; Fri, 4 Apr 2014 17:26:35 -0400 (EDT) +Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) + by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id s34LQXSH031635; + Fri, 4 Apr 2014 17:26:35 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id s34LQVui001759 + (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); + Fri, 4 Apr 2014 17:26:33 -0400 +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80) + (envelope-from ) + id 1WWBd9-00041T-Db; Fri, 04 Apr 2014 17:26:31 -0400 +Date: Fri, 4 Apr 2014 17:26:31 -0400 +From: Austin Clements +To: Jani Nikula +Subject: Re: [PATCH v5 0/2] lib: drop mbox support, replace header parser + with gmime +Message-ID: <20140404212557.GB6404@mit.edu> +References: +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFmpkleLIzCtJLcpLzFFi42IR4hRV1u1Wtg82WPRMzKJpurPF9ZszmR2Y + PG7df83u8WzVLeYApigum5TUnMyy1CJ9uwSujP/XnzMV/Gat2L4qpIHxNEsXIyeHhICJxObp + n9kgbDGJC/fWA9lcHEICs5kkbr1+zAySEBLYwChxf6UIROIUk8SbszehqpYwSkzc0wHWziKg + IrFg0WpWEJtNQENi2/7ljCC2iICixOaT+8FsZgFpiW+/m5lAbGGBMIllf3vBzuAV0JY4eHAK + K8Q2I4kpV66zQcQFJU7OfMIC0aslcePfS6BeDrA5y/9xgIQ5BYwlph5/B1YiCnTClJPb2CYw + Cs1C0j0LSfcshO4FjMyrGGVTcqt0cxMzc4pTk3WLkxPz8lKLdI30cjNL9FJTSjcxgkNakncH + 47uDSocYBTgYlXh4O3bYBQuxJpYVV+YeYpTkYFIS5e1SsA8W4kvKT6nMSCzOiC8qzUktPsQo + wcGsJMLL8ROonDclsbIqtSgfJiXNwaIkzvvW2ipYSCA9sSQ1OzW1ILUIJivDwaEkwVujBDRU + sCg1PbUiLTOnBCHNxMEJMpwHaPgBkBre4oLE3OLMdIj8KUZFKXFeZ5CEAEgiozQPrheWcl4x + igO9Isw7H6SKB5iu4LpfAQ1mAhrcEAZydXFJIkJKqoFxD8unbSIP4v/8qLd3mvaWxUydjd9h + nla5kOuChv3+f3Y5pNtaL32goK/+xNJ3f8KLFq53kU/tdXzm/P2qVbvMU0ql7fSzbVHnOD1f + TWOv3XJNnum9m5wU/6olBxbvZlj+Lb+u/gwf50wxlbYvZpp2z+zNd825Ef/1xrs+ja6/UV9z + Yv+dydZTYinOSDTUYi4qTgQAdHeKThQDAAA= +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 04 Apr 2014 21:26:43 -0000 + +LGTM. + +Quoth Jani Nikula on Mar 31 at 12:21 am: +> This is v5 of id:1395604866-19188-1-git-send-email-jani@nikula.org +> addressing Austin's review. The most significant change is the new patch +> dropping support for single-message mbox files. Diff between the +> versions is at the end of this cover letter. +> +> BR, +> Jani. +> +> +> Jani Nikula (2): +> lib: drop support for single-message mbox files +> lib: replace the header parser with gmime +> +> lib/database.cc | 15 +- +> lib/index.cc | 72 +-------- +> lib/message-file.c | 413 ++++++++++++++++++++------------------------------ +> lib/notmuch-private.h | 55 +++---- +> test/T050-new.sh | 26 ++-- +> 5 files changed, 216 insertions(+), 365 deletions(-) +>