From: Justus Winter <4winter@informatik.uni-hamburg.de> Date: Wed, 24 Apr 2013 09:41:02 +0000 (+0200) Subject: Re: [PATCH] go: use a different goconfig package X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=68eea8fc1706344f7b555e3d4e66c20a89c2cada;p=notmuch-archives.git Re: [PATCH] go: use a different goconfig package --- diff --git a/8c/90e91e0ae9244c91e5c02c0c5d31436ee36c47 b/8c/90e91e0ae9244c91e5c02c0c5d31436ee36c47 new file mode 100644 index 000000000..e6a783999 --- /dev/null +++ b/8c/90e91e0ae9244c91e5c02c0c5d31436ee36c47 @@ -0,0 +1,109 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 38A0C431FBC + for ; Wed, 24 Apr 2013 02:42:19 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id vnmOE3wvtIL3 for ; + Wed, 24 Apr 2013 02:42:18 -0700 (PDT) +Received: from mail.cryptobitch.de (cryptobitch.de [88.198.7.68]) + (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 5F155431FB6 + for ; Wed, 24 Apr 2013 02:42:18 -0700 (PDT) +Received: from mail.jade-hamburg.de (mail.jade-hamburg.de [85.183.11.228]) + (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by mail.cryptobitch.de (Postfix) with ESMTPSA id 57D8E605F2B + for ; Wed, 24 Apr 2013 11:42:09 +0200 (CEST) +Received: by mail.jade-hamburg.de (Postfix, from userid 401) + id B2F08DF2A5; Wed, 24 Apr 2013 11:42:08 +0200 (CEST) +Received: from thinkbox.jade-hamburg.de (thinkbox.jadE-Hamburg.de + [10.1.1.109]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No + client certificate requested) (Authenticated sender: teythoon) by + mail.jade-hamburg.de (Postfix) with ESMTPSA id A96DDDF29F; Wed, 24 Apr 2013 + 11:42:06 +0200 (CEST) +Received: from teythoon by thinkbox.jade-hamburg.de with local (Exim 4.80) + (envelope-from ) + id 1UUwCE-00073a-Uh; Wed, 24 Apr 2013 11:41:02 +0200 +Content-Type: text/plain; charset="utf-8" +MIME-Version: 1.0 +Content-Transfer-Encoding: quoted-printable +From: Justus Winter <4winter@informatik.uni-hamburg.de> +User-Agent: alot/0.3.3+ +To: David Bremner , notmuch@notmuchmail.org +References: + <1366729987-16925-1-git-send-email-4winter@informatik.uni-hamburg.de> + <87d2tkoo80.fsf@zancas.localnet> +In-Reply-To: <87d2tkoo80.fsf@zancas.localnet> +Message-ID: <20130424094102.7753.16880@thinkbox.jade-hamburg.de> +Subject: Re: [PATCH] go: use a different goconfig package +Date: Wed, 24 Apr 2013 11:41:02 +0200 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 24 Apr 2013 09:42:19 -0000 + +Quoting David Bremner (2013-04-24 00:51:11) +> Justus Winter <4winter@informatik.uni-hamburg.de> writes: +> = + +> > The notmuch-addrlookup utility uses a third party library to read the +> > notmuch configuration file. The previously used implementation at +> > "github.com/kless/goconfig" vanished, so this patch switches to the +> > implementation at "github.com/msbranco/goconfig". As the +> > implementations differ at the API level, the code is updated +> > accordingly. +> = + +> It's great that you fixed this, but the whole idea of something failing +> to build depending on the status of a website makes me pretty +> uncomfortable. +> = + +> d + +Ah, I pondered whether I should write more about the lib change. Maybe +I should have. + +So there are two libs, kless and msbranco for short. kless is a fork +of msbranco, and it seems like the author abandoned his fork. So we +are now using the original lib, msbranco. msbranco seems to be in +"maintenance" mode, but has recently received updates to fix some +minor issues wrt. go 1.1. There are a lot of forks of msbranco on +github, so even if msbranco vanishes as well, we can pick the next +most promising fork. + +So yeah, I feel the same way, it's unfortunately that I had to patch +this, but we're better of now (it builds again and we moved to a more +"vanilla" goconfig API (assuming the other forks do not change the api +as much as kless did)). + +And I think you are being a bit harsh with the "status of the website" +comment. In case you are not familiar with go, +"github.com/kless/goconfig" is a package path, not a website. It just +happens to also be the host+resource part of a URL that points to the +github project page. So what happened here is that the VCS repository +specified by the package path vanished, not some web site (well, that +vanished too, but that didn't cause the build failure). If you happen +to have golang installed, type "go help remote" for more information. + +Cheers, +Justus