From: David Edmondson Date: Tue, 13 May 2014 10:01:58 +0000 (+0100) Subject: Re: [PATCH v3 0/9] emacs: Improve the cited message included in replies X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=68b075e41a3f671fe1d86e1d7b5d0174237161f4;p=notmuch-archives.git Re: [PATCH v3 0/9] emacs: Improve the cited message included in replies --- diff --git a/a5/2b547948328d160f89e82d0b53bbdb1d67c038 b/a5/2b547948328d160f89e82d0b53bbdb1d67c038 new file mode 100644 index 000000000..005b0421c --- /dev/null +++ b/a5/2b547948328d160f89e82d0b53bbdb1d67c038 @@ -0,0 +1,195 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1C1CE431FBD + for ; Tue, 13 May 2014 03:02:15 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id s+LVSQHiwBMh for ; + Tue, 13 May 2014 03:02:07 -0700 (PDT) +Received: from mail-we0-f169.google.com (mail-we0-f169.google.com + [74.125.82.169]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 39E19431FAF + for ; Tue, 13 May 2014 03:02:07 -0700 (PDT) +Received: by mail-we0-f169.google.com with SMTP id u56so119807wes.28 + for ; Tue, 13 May 2014 03:02:06 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:to:subject:in-reply-to:references:user-agent + :from:date:message-id:mime-version:content-type; + bh=3DThrqgYVORoc4xFdqPog6dPgYfLOJewrgMnGXddAUo=; + b=Hdz3YMnugQdkJWid4gDTKz//pIs7bfuIjPm2c9+69TeQ24Wy1zUimnxAOSwc7X/FQV + mYeGfdZECgvCDCdhPojNw/zZTp+0cCOgEB1Xj76eEmZ7Dc0wgUzKDxc7tfPHiRODXe9v + eOjriNMXFs2kK4YqDqMWHf4h0M+kmU3DDOJmwoDpD/hpoRSrtYdhgn7akOLoyjCeNUgA + fL2Gd7UB29913c9rJaBKfD2uSZ895MkP+FVSmz9fnQqxT25Gcly+vQuYEv9oo67ZRhfG + OaeEvH/nUEjTDZx6icH5yPkyzEljGxl13rcNgOfHMY9IPKogl5I2q4ydbDJN3XLWgPlh + eEYQ== +X-Gm-Message-State: + ALoCoQnGy1YTqKSAb1nHsNHODpOvB+shFxpNTJ9n/nJm9jEXdR8QZbvpiq2mceT+JzMXdSFjqhsA +X-Received: by 10.180.99.40 with SMTP id en8mr20470196wib.24.1399975324912; + Tue, 13 May 2014 03:02:04 -0700 (PDT) +Received: from localhost ([2a01:348:1a2:1:a288:b4ff:fe8a:77d8]) + by mx.google.com with ESMTPSA id + mw4sm21035587wib.12.2014.05.13.03.02.02 for + (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Tue, 13 May 2014 03:02:03 -0700 (PDT) +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH v3 0/9] emacs: Improve the cited message included in + replies +In-Reply-To: <87vbtak5uz.fsf@qmul.ac.uk> +References: <87sixdujkv.fsf@qmul.ac.uk> + <1399897769-26809-1-git-send-email-dme@dme.org> + <87vbtak5uz.fsf@qmul.ac.uk> +User-Agent: Notmuch/0.18 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +From: David Edmondson +Date: Tue, 13 May 2014 11:01:58 +0100 +Message-ID: +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha1; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 13 May 2014 10:02:15 -0000 + +--=-=-= +Content-Type: text/plain +Content-Transfer-Encoding: quoted-printable + +Firstly, I don't think that the code resulting from this patch series is +beyond improvement - the intention was really only that it be better +than the current implementation. + +On Mon, May 12 2014, Mark Walters wrote: +> On Mon, 12 May 2014, David Edmondson wrote: +>> emacs: Improve the cited message included in replies +>> +>> I tried to do things in small increments to make it easier to review. +>> +>> v2: +>> - Don't run the text/plain hooks when generating the message to quote. +>> +>> v3: +>> - Remove the 'no-button code, as it's no longer used. +>> - Control the insertion of part headers using a function. +>> - Fix the tests. +> +> I think I broadly like this series. I haven't thought through all the +> ramifications yet so this is just some first thoughts. I will also send +> some comments on individual patches. + +Thanks! + +> In notmuch-show we go to notmuch-show-insert-part-*/* to +> notmuch-mm-display-part-inline and then leave the decision to inline to +> mm-inlined-types. I think this means that, by default, we will not +> inline signatures amongst other things. + +The rule is essentially: whatever text would be shown when the message +is displayed for reading, without any of the washing. + +> So at the least I think we should decide whether we want to override +> mm-inlined-types. + +I'm not really clear on the benefits of this. Could you explain? + +> Alternatively, and in my view preferably, we could have a function or +> variable of our own which says which parts to include. Indeed, if do +> it with a function we might be able to make an option to reply to mean +> "include parts currently shown in the notmuch-show buffer" which might +> be nice. + +That seems over complicated to me. The rule (above) from this series +is easy to understand and work with. Other mechanisms could be +implemented later, of course. + +> There is a related question and possible bug that we might be able to +> do something about at the same time: should we include text parts in the +> reply if they have content-disposition attachment? I have been caught +> about by this on one occasion replying to a message with a 500K log file +> attached (and notmuch-show/wash becomes very slow with a 500K +> message!) + +This is really a question of what happens in `show' mode. If it is +currently displaying text parts with content-disposition attachment, +that sounds like a bug that should be fixed (which would mean that the +cited message wouldn't include that part either). + +> Finally, I am not sure whether I like having buttons in the reply. My +> instinct is against, but they do add context. + +The last patch in the series is an example of trying to do the right +thing - show the part headers when they are necessary for proper +understanding, but elide them in all other cases. + +The mechanism used to do this is pretty crude in the patch. One could +imagine a better implementation that examines the depth of the part +tree, etc. + +> Best wishes +> +> Mark +> +> +> +> +>> +>> +>> David Edmondson (9): +>> emacs/show: Re-arrange determination if a part header is necessary +>> emacs/show: Allow the user to decide when part headers should be +>> inserted +>> emacs/show: Accommodate the lack of part header buttons +>> emacs/mua: Generate improved cited text for replies +>> emacs/show: Remove the 'no-buttons option of +>> `notmuch-show-insert-bodypart' +>> emacs/mua: Don't insert part headers in citations +>> test: Update the test output to accord with the reply changes +>> emacs/mua: Insert part headers depending on the message +>> test: Update the test output to accord with more reply changes +>> +>> emacs/notmuch-mua.el | 82 +++++++++++++++++++----------- +>> emacs/notmuch-show.el | 135 +++++++++++++++++++++++++++++++------------= +------- +>> test/T310-emacs.sh | 44 ++++++++++++++++ +>> 3 files changed, 180 insertions(+), 81 deletions(-) +>> +>> --=20 +>> 2.0.0.rc0 +>> +>> _______________________________________________ +>> notmuch mailing list +>> notmuch@notmuchmail.org +>> http://notmuchmail.org/mailman/listinfo/notmuch + +--=-=-= +Content-Type: application/pgp-signature; name="signature.asc" + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1 + +iKYEARECAGYFAlNx7ZZfFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl +bnBncC5maWZ0aGhvcnNlbWFuLm5ldDc1M0Y5NDJDMEExNjc3MDE4OURGMUYyMDY5 +RUNEMEFCRjA0OTY1MTYACgkQaezQq/BJZRYq8QCeOUu0kzUhaHypeKMf94pxt/7+ +aacAoIyc1cHTTjq2CoeLeIs8WUqH9ok7 +=Xbt6 +-----END PGP SIGNATURE----- +--=-=-=--