From: Ezra Peisach <epeisach@mit.edu>
Date: Fri, 20 Nov 2009 20:55:34 +0000 (+0000)
Subject: Correct argument to kadm5_get_principal is a pointer to a struct - not
X-Git-Tag: krb5-1.8-alpha1~169
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=6891e67a2c4b364195499bd6d3e0f0f721d11791;p=krb5.git

Correct argument to kadm5_get_principal is a pointer to a struct - not
a pointer to a pointer.... Does not really matter as the field is not used -
this test program expects a failer.

Clean up memory leaks by freeing principal and releasing context.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@23295 dc483132-0cff-0310-8789-dd5450dbe970
---

diff --git a/src/lib/kadm5/unit-test/handle-test.c b/src/lib/kadm5/unit-test/handle-test.c
index 9f0e3feaa..a77bc1195 100644
--- a/src/lib/kadm5/unit-test/handle-test.c
+++ b/src/lib/kadm5/unit-test/handle-test.c
@@ -21,7 +21,8 @@ int main(int argc, char *argv[])
     kadm5_server_handle_t handle;
     kadm5_server_handle_rec orig_handle;
     kadm5_policy_ent_rec       pol;
-    kadm5_principal_ent_t      princ;
+    kadm5_principal_ent_t    princ;
+    kadm5_principal_ent_rec  kprinc;
     krb5_keyblock      *key;
     krb5_principal     tprinc;
     krb5_context       context;
@@ -40,7 +41,7 @@ int main(int argc, char *argv[])
     orig_handle = *handle;
     handle->magic_number = KADM5_STRUCT_VERSION;
     krb5_parse_name(context, "testuser", &tprinc);
-    ret = kadm5_get_principal(server_handle, tprinc, &princ,
+    ret = kadm5_get_principal(server_handle, tprinc, &kprinc,
                               KADM5_PRINCIPAL_NORMAL_MASK);
     if(ret != KADM5_BAD_SERVER_HANDLE) {
         fprintf(stderr, "%s -- returned -- %s\n", "get-principal",
@@ -55,6 +56,7 @@ int main(int argc, char *argv[])
         exit(1);
     }
 
+    princ = &kprinc;
     ret = kadm5_create_principal(server_handle, princ, KADM5_PRINCIPAL, "pass");
     if(ret != KADM5_BAD_SERVER_HANDLE) {
         fprintf(stderr, "%s -- returned -- %s\n", "create-principal",
@@ -132,5 +134,7 @@ int main(int argc, char *argv[])
         exit(1);
     }
 
+    krb5_free_principal(context, tprinc);
+    krb5_free_context(context);
     exit(0);
 }