From: David Bremner Date: Sun, 14 Jun 2015 06:53:41 +0000 (+0200) Subject: Re: [PATCH] lib, ruby: make use of -Wl,--no-undefined configurable X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=6847aaef88bb1a49fff9c0588b0bb8895c69942d;p=notmuch-archives.git Re: [PATCH] lib, ruby: make use of -Wl,--no-undefined configurable --- diff --git a/b4/fa30019307fe614c77975609659ca660cc6f81 b/b4/fa30019307fe614c77975609659ca660cc6f81 new file mode 100644 index 000000000..af65f8d3a --- /dev/null +++ b/b4/fa30019307fe614c77975609659ca660cc6f81 @@ -0,0 +1,83 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 63C6B6DE0948 + for ; Sat, 13 Jun 2015 23:57:02 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 0.189 +X-Spam-Level: +X-Spam-Status: No, score=0.189 tagged_above=-999 required=5 tests=[AWL=0.189] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id eRwUbcW8aTJ4 for ; + Sat, 13 Jun 2015 23:57:00 -0700 (PDT) +Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net + [87.98.215.224]) + by arlo.cworth.org (Postfix) with ESMTPS id 18BCD6DE0350 + for ; Sat, 13 Jun 2015 23:57:00 -0700 (PDT) +Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim + 4.80) (envelope-from ) + id 1Z41pL-0002w0-U4; Sun, 14 Jun 2015 06:55:31 +0000 +Received: (nullmailer pid 25159 invoked by uid 1000); Sun, 14 Jun 2015 + 06:53:41 -0000 +From: David Bremner +To: Jinwoo Lee , notmuch@notmuchmail.org +Subject: Re: [PATCH] lib, ruby: make use of -Wl,--no-undefined configurable +In-Reply-To: +References: <1433142542-2307-3-git-send-email-david@tethera.net> + <1434261524-14139-1-git-send-email-david@tethera.net> + +User-Agent: Notmuch/0.20.1+21~g4e79903 (http://notmuchmail.org) Emacs/24.4.1 + (x86_64-pc-linux-gnu) +Date: Sun, 14 Jun 2015 08:53:41 +0200 +Message-ID: <87r3peye4q.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 14 Jun 2015 06:57:02 -0000 + +Jinwoo Lee writes: + +> There are 2 problems. +> +> 1. The file, bindings/Makefile.local still has lib/libnotmuch.so as the +> dependency of ruby-bindings. + +this is fixed in + + id:1434263191-14171-1-git-send-email-david@tethera.net + +an updated patch sent a few minutes ago. + +> +>> cd bindings/ruby && \ +>> EXTRA_LDFLAGS="" \ +>> ruby extconf.rb --vendor +>> checking for notmuch_database_create in libnotmuch.so... no +>> *** extconf.rb failed *** + +This should also be fixed by the same patch, since that test is +eliminated. + +> ld: warning: ignoring file ../../lib/libnotmuch.dylib, file was built for x86_64 which is not the architecture being linked (i386): ../../lib/libnotmuch.dylib + +On the other hand, this suggests there is still something broken with +building the ruby extensions on mac. I think if noone has a better idea, +and the updated versions of the two patches I sent to the list this +morning don't help, I'll just add a "--without-ruby" option to the +config script. In the long run, we probably want such an option anyway. +