From: Joey Hess <joey@kitenet.net>
Date: Tue, 18 Dec 2007 00:25:44 +0000 (-0500)
Subject: * Work around perl taint checking bug #411786, where perl sometimes randomly
X-Git-Tag: 2.16~3
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=67dcf175cbe6241f0dcf3564424ca178476ebdfb;p=ikiwiki.git

* Work around perl taint checking bug #411786, where perl sometimes randomly
  sets the taint flag on untainted variables, by disabling taint checking
  in the deb. This sucks.
---

diff --git a/debian/changelog b/debian/changelog
index 3d9f01207..fe3c6b16c 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -59,6 +59,9 @@ ikiwiki (2.16) UNRELEASED; urgency=low
   * Re-organise dependencies and recommends now that recommends are installed
     by default.
   * Don't refuse to render files with ".." in their name. (Anchor the regexp.)
+  * Work around perl taint checking bug #411786, where perl sometimes randomly
+    sets the taint flag on untainted variables, by disabling taint checking
+    in the deb. This sucks.
 
  -- Joey Hess <joeyh@debian.org>  Sun, 16 Dec 2007 16:55:23 -0500
 
diff --git a/debian/rules b/debian/rules
index af33131d9..ef0e7f827 100755
--- a/debian/rules
+++ b/debian/rules
@@ -4,7 +4,8 @@ build: build-stamp
 build-stamp:
 	dh_testdir
 	perl Makefile.PL PREFIX=/usr INSTALLDIRS=vendor
-	$(MAKE)
+	# taint checking disabled due to perl bug #411786
+	$(MAKE) NOTAINT=1
 	$(MAKE) test
 	touch build-stamp
 
diff --git a/doc/bugs/Insecure_dependency_in_mkdir.mdwn b/doc/bugs/Insecure_dependency_in_mkdir.mdwn
index 4c7d8ebbe..68fb2cb57 100644
--- a/doc/bugs/Insecure_dependency_in_mkdir.mdwn
+++ b/doc/bugs/Insecure_dependency_in_mkdir.mdwn
@@ -59,5 +59,5 @@ I can't see any related entries. Any ideas?
 >> --[[Joey]]
 
 >> I'd forgotten about [this perl bug](http://bugs.debian.org/411786).
->> If your problem is that bug, I can't help, it's a real bug in perl.
->> --[[Joey]]
+>> All I can do is work around it by disabling the taint checking. :-(
+>> (Which I've [[done]].) --[[Joey]]