From: David Bremner <david@tethera.net>
Date: Tue, 4 Nov 2014 06:38:22 +0000 (+0100)
Subject: Re: [PATCH v2 05/10] cli: add support for hierarchical command line option arrays
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=67753b07cd7be1ff69bec6a72c93f46afb6c299d;p=notmuch-archives.git

Re: [PATCH v2 05/10] cli: add support for hierarchical command line option arrays
---

diff --git a/7a/faee833f15767a465d638fd7962662f297241d b/7a/faee833f15767a465d638fd7962662f297241d
new file mode 100644
index 000000000..942202950
--- /dev/null
+++ b/7a/faee833f15767a465d638fd7962662f297241d
@@ -0,0 +1,69 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 0ACA0429E31
+	for <notmuch@notmuchmail.org>; Mon,  3 Nov 2014 22:38:36 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id aD0ll5G5ucOl for <notmuch@notmuchmail.org>;
+	Mon,  3 Nov 2014 22:38:28 -0800 (PST)
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
+	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id 2D455431FAE
+	for <notmuch@notmuchmail.org>; Mon,  3 Nov 2014 22:38:28 -0800 (PST)
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
+	(envelope-from <david@tethera.net>)
+	id 1XlXl5-0001eO-NH; Tue, 04 Nov 2014 02:38:27 -0400
+Received: (nullmailer pid 22517 invoked by uid 1000); Tue, 04 Nov 2014
+	06:38:22 -0000
+From: David Bremner <david@tethera.net>
+To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org
+Subject: Re: [PATCH v2 05/10] cli: add support for hierarchical command line
+	option arrays
+In-Reply-To: <87ioivmpzx.fsf@maritornes.cs.unb.ca>
+References: <1415058622-21162-1-git-send-email-sojkam1@fel.cvut.cz>
+	<1415058622-21162-6-git-send-email-sojkam1@fel.cvut.cz>
+	<87ioivmpzx.fsf@maritornes.cs.unb.ca>
+User-Agent: Notmuch/0.18.2+156~g3cc8ed5 (http://notmuchmail.org) Emacs/24.4.1
+	(x86_64-pc-linux-gnu)
+Date: Tue, 04 Nov 2014 07:38:22 +0100
+Message-ID: <87fvdzmpwh.fsf@maritornes.cs.unb.ca>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Tue, 04 Nov 2014 06:38:36 -0000
+
+David Bremner <david@tethera.net> writes:
+
+> Michal Sojka <sojkam1@fel.cvut.cz> writes:
+>
+>> From: Jani Nikula <jani@nikula.org>
+>>
+>> NOTMUCH_OPT_INHERIT expects a notmuch_opt_desc_t * pointer in
+>> output_var.
+>
+> At the risk of bikeshedding, what about NOTMUCH_OPT_RECURSE instead of
+> _INHERIT?
+
+Hrm. Now that I read the next patch, I retract my suggestion.
+
+d