From: Theodore Tso <tytso@mit.edu>
Date: Thu, 19 Jan 1995 02:46:40 +0000 (+0000)
Subject: Oops in previous memory freeing fixes; was a bit too agressive freeing things
X-Git-Tag: krb5-1.0-beta5~832
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=66da8ab874ad3b91581850cd306bcbf64b9f40f5;p=krb5.git

Oops in previous memory freeing fixes; was a bit too agressive freeing things

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@4823 dc483132-0cff-0310-8789-dd5450dbe970
---

diff --git a/src/lib/krb5/krb/mk_req_ext.c b/src/lib/krb5/krb/mk_req_ext.c
index 585ebde20..b4d60177a 100644
--- a/src/lib/krb5/krb/mk_req_ext.c
+++ b/src/lib/krb5/krb/mk_req_ext.c
@@ -205,7 +205,7 @@ cleanup:
 		      request.authenticator.ciphertext.length);
 	free(request.authenticator.ciphertext.data);
     }
-    if (newkey && *newkey)
+    if (retval && newkey && *newkey)
 	krb5_free_keyblock(context, *newkey);
     if (scratch) {
 	memset(scratch->data, 0, scratch->length);