From: Zac Medico <zmedico@gentoo.org>
Date: Fri, 22 Jun 2007 12:57:41 +0000 (-0000)
Subject: Add a note about potential for config mixups in elog finalizers.
X-Git-Tag: v2.2_pre1~1192
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=64b2c8afce029d04cb1de1f4377fe64eb546826f;p=portage.git

Add a note about potential for config mixups in elog finalizers.

svn path=/main/trunk/; revision=6952
---

diff --git a/pym/portage/elog/__init__.py b/pym/portage/elog/__init__.py
index 5b8ac44c3..1cf4dd8b8 100644
--- a/pym/portage/elog/__init__.py
+++ b/pym/portage/elog/__init__.py
@@ -95,6 +95,11 @@ def elog_process(cpv, mysettings):
 					m.process(mysettings, str(key), mod_logentries, mod_fulllog)
 				finally:
 					signal.alarm(0)
+				# FIXME: when installing to more than one $ROOT, the finalizer
+				# will only be registered with a config instance from one of
+				# the roots (randomly).  With PORTAGE_CONFIGROOT, the config
+				# instances can have completely different settings, so
+				# logs can end up in the wrong PORT_LOGDIR for example.
 				if hasattr(m, "finalize") and not m.finalize in _elog_atexit_handlers:
 					_elog_atexit_handlers.append(m.finalize)
 					atexit_register(m.finalize, mysettings)