From: Mark Walters Date: Tue, 22 Oct 2013 21:43:53 +0000 (+0100) Subject: Re: [PATCH 0/8] Improve tag change completion X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=646b18961bd4d495c9529b02426250da37f7b01b;p=notmuch-archives.git Re: [PATCH 0/8] Improve tag change completion --- diff --git a/d7/8784ac48547a2d09de3a55f647dfd1c25102ff b/d7/8784ac48547a2d09de3a55f647dfd1c25102ff new file mode 100644 index 000000000..a60a67c38 --- /dev/null +++ b/d7/8784ac48547a2d09de3a55f647dfd1c25102ff @@ -0,0 +1,130 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 2A955429E21 + for ; Tue, 22 Oct 2013 14:44:12 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 1.401 +X-Spam-Level: * +X-Spam-Status: No, score=1.401 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + FREEMAIL_REPLY=2.499, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id hmrjTVJ+H8Zo for ; + Tue, 22 Oct 2013 14:44:06 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 012A6431FDE + for ; Tue, 22 Oct 2013 14:44:05 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1VYjk3-0006l5-4a; Tue, 22 Oct 2013 22:43:57 +0100 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1VYjk2-0005zE-Pa; Tue, 22 Oct 2013 22:43:54 +0100 +From: Mark Walters +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH 0/8] Improve tag change completion +In-Reply-To: <1382471457-26056-1-git-send-email-amdragon@mit.edu> +References: <1382471457-26056-1-git-send-email-amdragon@mit.edu> +User-Agent: Notmuch/0.16 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Tue, 22 Oct 2013 22:43:53 +0100 +Message-ID: <87mwm1x9pi.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: e0c77d7dadca19c97f6dc04e6a0b8e19 (of first 20000 bytes) +X-SpamAssassin-Score: 0.6 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored 0.6 points. Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * 1.0 FREEMAIL_REPLY From and body contain different freemails + * -0.4 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 22 Oct 2013 21:44:12 -0000 + + +This looks good to me +1. It makes the code clearer and nicer to read as +well as giving a better user experience, and it is makes fixing the long +standing tagging races simpler. + +I have a couple of docstring comments: + +In patch 2 perhaps notmuch-tag-completions could have a docstring. + +In Patch 4 I think the docstring for notmuch-search-tag is outdated: it + is "Change tags for the currently selected thread or region." but + beg and end can now be specified by the caller. + +and one actual comment: + +in patch 3 (for show) delete-dups is called before the list is passed to +notmuch-read-tag-changes whereas it is not for search or pick. +Obviously this is not actually a problem but it might be worth being +consistent. + +But that was all I found. All tests pass and everything I try behaves +exactly as expected. + +Best wishes + +Mark + + +On Tue, 22 Oct 2013, Austin Clements wrote: +> This series improves tag change completion in various ways for +> commands like +, -, and *. +> +> From a user perspective, this provides command-specific prompts like +> "Tag message" and "Tag all" instead of the generic "Tag" prompt, and +> bases tag removal completions on the tags that are in the buffer, +> rather than the current tags in the database, providing a more +> predicable experience. +> +> From an implementation perspective, this new tag removal completion +> behavior improves efficiency and eliminates a road block to fixing the +> tagging race bug (which otherwise results in massive queries just to +> compute removal completions). The new code is also more "Elispy" and +> predictable because all tag change prompting now occurs at the +> interactive entry points, rather than buried under several layers of +> non-interactive calls. +> +> This is a spiritual successor to +> id:1354263691-19715-1-git-send-email-markwalters1009@gmail.com, though +> it takes a very different approach. This is also a prerequisite to +> the tag race fix in +> id:1381185201-25197-1-git-send-email-amdragon@mit.edu and I plan to +> send an updated version of that series when this one is accepted. +> +> Patches 1, 5, and 6 could be pushed on their own. They fix bugs or +> sort of bugs that get in the way of the rest of the series. +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch