From: Michal Sojka Date: Sat, 20 Sep 2014 08:04:08 +0000 (+0200) Subject: Re: [PATCH] cli: add --output=address-{from, to, all} to notmuch search X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=633180c24af64e302e7f20c499aa1e7b5b72d822;p=notmuch-archives.git Re: [PATCH] cli: add --output=address-{from, to, all} to notmuch search --- diff --git a/e8/630366f4b08ba9256ebed7b46ee43a1a9cc776 b/e8/630366f4b08ba9256ebed7b46ee43a1a9cc776 new file mode 100644 index 000000000..c72a86e09 --- /dev/null +++ b/e8/630366f4b08ba9256ebed7b46ee43a1a9cc776 @@ -0,0 +1,87 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 14053431FAF + for ; Sat, 20 Sep 2014 01:04:27 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.3 +X-Spam-Level: +X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id YWUJOs0kGQTl for ; + Sat, 20 Sep 2014 01:04:21 -0700 (PDT) +Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36]) + by olra.theworths.org (Postfix) with ESMTP id 9A1AE431FAE + for ; Sat, 20 Sep 2014 01:04:21 -0700 (PDT) +Received: from localhost (unknown [192.168.200.7]) + by max.feld.cvut.cz (Postfix) with ESMTP id 5769D3CFE87; + Sat, 20 Sep 2014 10:04:19 +0200 (CEST) +X-Virus-Scanned: IMAP STYX AMAVIS +Received: from max.feld.cvut.cz ([192.168.200.1]) + by localhost (styx.feld.cvut.cz [192.168.200.7]) (amavisd-new, + port 10044) + with ESMTP id aNw2MiXCtBF5; Sat, 20 Sep 2014 10:04:15 +0200 (CEST) +Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34]) + by max.feld.cvut.cz (Postfix) with ESMTP id 011E33CFE82; + Sat, 20 Sep 2014 10:04:14 +0200 (CEST) +Received: from wsh by steelpick.2x.cz with local (Exim 4.84) + (envelope-from ) + id 1XVFeK-0006AJ-0U; Sat, 20 Sep 2014 10:04:08 +0200 +From: Michal Sojka +To: David Bremner , Jani Nikula , + notmuch@notmuchmail.org +Subject: Re: [PATCH] cli: add --output=address-{from, to, + all} to notmuch search +In-Reply-To: <87k34zbcy3.fsf@maritornes.cs.unb.ca> +References: <871troub1v.fsf@qmul.ac.uk> + <1410021689-15901-1-git-send-email-jani@nikula.org> + <87k34zbcy3.fsf@maritornes.cs.unb.ca> +User-Agent: Notmuch/0.18.1+94~gceee2d7 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sat, 20 Sep 2014 10:04:08 +0200 +Message-ID: <87tx427m6f.fsf@steelpick.2x.cz> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 20 Sep 2014 08:04:27 -0000 + +On Fri, Sep 19 2014, David Bremner wrote: +> Jani Nikula writes: +> +>> + if (name && *name) +>> + full_address = talloc_asprintf (NULL, "%s <%s>", name, addr); +>> + else +>> + full_address = talloc_asprintf (NULL, "<%s>", addr +> +> Is there some reason not to use sprinter as a talloc context here? +> +>> + +>> + if (!full_address) +>> + break; +> +> Is the error here out of memory? Maybe an error message would be a good +> idea. +> +> +> Obviously the docs need to be updated as well, and ideally the tests. I +> think Jani was hinting that he didn't want to be the person to do +> that. Any volunteers? + +Yes, I'll look at that. It will probably take me a few days. + +-Michal