From: David Bremner Date: Sat, 26 Mar 2016 18:13:47 +0000 (+2100) Subject: Re: [Patch v2 09/13] CLI: add optional config data to dump output. X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=62fa5893cdd7d4f285587a5fb9027a6017f6dde3;p=notmuch-archives.git Re: [Patch v2 09/13] CLI: add optional config data to dump output. --- diff --git a/9a/bc459fb25b1411cfdb66c4a7b293a9032b2c67 b/9a/bc459fb25b1411cfdb66c4a7b293a9032b2c67 new file mode 100644 index 000000000..36b150286 --- /dev/null +++ b/9a/bc459fb25b1411cfdb66c4a7b293a9032b2c67 @@ -0,0 +1,69 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 6E0896DE026C + for ; Sat, 26 Mar 2016 11:13:59 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.026 +X-Spam-Level: +X-Spam-Status: No, score=-0.026 tagged_above=-999 required=5 + tests=[AWL=-0.015, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id sEaihRchzxvc for ; + Sat, 26 Mar 2016 11:13:51 -0700 (PDT) +Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) + by arlo.cworth.org (Postfix) with ESMTPS id 321D86DE00F1 + for ; Sat, 26 Mar 2016 11:13:50 -0700 (PDT) +Received: from remotemail by fethera.tethera.net with local (Exim 4.84) + (envelope-from ) + id 1ajsjB-000196-JV; Sat, 26 Mar 2016 14:14:25 -0400 +Received: (nullmailer pid 25618 invoked by uid 1000); + Sat, 26 Mar 2016 18:13:47 -0000 +From: David Bremner +To: notmuch@notmuchmail.org +Subject: Re: [Patch v2 09/13] CLI: add optional config data to dump output. +In-Reply-To: <1459015043-8460-10-git-send-email-david@tethera.net> +References: <1459015043-8460-1-git-send-email-david@tethera.net> + <1459015043-8460-10-git-send-email-david@tethera.net> +User-Agent: Notmuch/0.21+5~gca076ce (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Sat, 26 Mar 2016 15:13:47 -0300 +Message-ID: <87y495ksys.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 26 Mar 2016 18:13:59 -0000 + +David Bremner writes: + +> Note that it changes the default dump output format, but doesn't break +> existing notmuch-restore. It might break user scripts though. + +blush. One of the things it breaks is nmbug. The quick and dirty fix +would be to have nmbug ignore any comment lines in the dump output. + +There is an option to the new dump (--include=tags) which omits the +config information, but it still adds a single header line. I'd be open +to the idea of omitting the header line if there is no config +information in the file. + +The other question is if the current default of including configuration +information is a good idea. For the most obvious use case of backing up the +user's data, it seems like the right thing to do. + +d