From: David Bremner Date: Fri, 18 Mar 2016 21:27:26 +0000 (+2100) Subject: Re: [PATCH v1] emacs: Don't insert part header pseudo-buttons during reply by default. X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=6285e500a72575592a202ee197369cde728d6bfa;p=notmuch-archives.git Re: [PATCH v1] emacs: Don't insert part header pseudo-buttons during reply by default. --- diff --git a/d6/f3cb0ad75d3c506e656402ab01100900c44c00 b/d6/f3cb0ad75d3c506e656402ab01100900c44c00 new file mode 100644 index 000000000..f3c16f35e --- /dev/null +++ b/d6/f3cb0ad75d3c506e656402ab01100900c44c00 @@ -0,0 +1,81 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id BA95B6DE02A6 + for ; Fri, 18 Mar 2016 14:27:36 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.03 +X-Spam-Level: +X-Spam-Status: No, score=-0.03 tagged_above=-999 required=5 tests=[AWL=-0.019, + SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id sa5y_L_ogpId for ; + Fri, 18 Mar 2016 14:27:28 -0700 (PDT) +Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) + by arlo.cworth.org (Postfix) with ESMTPS id BE1086DE02A5 + for ; Fri, 18 Mar 2016 14:27:28 -0700 (PDT) +Received: from remotemail by fethera.tethera.net with local (Exim 4.84) + (envelope-from ) + id 1ah1wC-0006ku-N9; Fri, 18 Mar 2016 17:28:04 -0400 +Received: (nullmailer pid 30050 invoked by uid 1000); + Fri, 18 Mar 2016 21:27:26 -0000 +From: David Bremner +To: David Edmondson , notmuch@notmuchmail.org +Subject: Re: [PATCH v1] emacs: Don't insert part header pseudo-buttons during + reply by default. +In-Reply-To: <1458117593-32586-1-git-send-email-dme@dme.org> +References: <1458117593-32586-1-git-send-email-dme@dme.org> +User-Agent: Notmuch/0.21+74~g6c60fb1 (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Fri, 18 Mar 2016 18:27:26 -0300 +Message-ID: <87k2kz329t.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 18 Mar 2016 21:27:36 -0000 + +David Edmondson writes: + +> Based on feedback from users, change the default value of +> `notmuch-mua-reply-insert-header-p-function' to +> `notmuch-show-reply-insert-header-p-never', with the consequence that +> replies will not have part header pseudo-buttons. This more closely +> matches the behaviour before the recent changes to the reply code. +> --- +> emacs/notmuch-mua.el | 2 +- +> 1 file changed, 1 insertion(+), 1 deletion(-) +> +> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el +> index fcb3e95..773a000 100644 +> --- a/emacs/notmuch-mua.el +> +++ b/emacs/notmuch-mua.el +> @@ -94,7 +94,7 @@ Note that these functions use `mail-citation-hook' if that is non-nil." +> :group 'notmuch-reply) +> +> (defcustom notmuch-mua-reply-insert-header-p-function +> - 'notmuch-show-reply-insert-header-p-trimmed +> + 'notmuch-show-reply-insert-header-p-never +> "Function to decide which parts get a header when replying. +> +> This function specifies which parts of a mime message with +> -- +> 2.1.4 + +I think I have small preference for Nicolas' version, so I'm marking +this as "obsolete". Please let me know and/or retag if you disagree. + +d