From: Mark Walters Date: Sun, 7 Feb 2016 23:57:18 +0000 (+0000) Subject: Re: [PATCH v2 0/2] Allow forwarding of all open messages in the current view. X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=62379ad6efdf3ad026ca0bf75f061e5f95d17b19;p=notmuch-archives.git Re: [PATCH v2 0/2] Allow forwarding of all open messages in the current view. --- diff --git a/46/288d4f4b9755a2a523eefcd9b143116cdafe17 b/46/288d4f4b9755a2a523eefcd9b143116cdafe17 new file mode 100644 index 000000000..6ca0034bb --- /dev/null +++ b/46/288d4f4b9755a2a523eefcd9b143116cdafe17 @@ -0,0 +1,123 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id B09846DE171E + for ; Sun, 7 Feb 2016 15:57:24 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.207 +X-Spam-Level: +X-Spam-Status: No, score=-0.207 tagged_above=-999 required=5 tests=[AWL=0.363, + DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, + RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id aoooWg2vl0Pq for ; + Sun, 7 Feb 2016 15:57:22 -0800 (PST) +Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com + [74.125.82.68]) by arlo.cworth.org (Postfix) with ESMTPS id BBC736DE0C4A for + ; Sun, 7 Feb 2016 15:57:21 -0800 (PST) +Received: by mail-wm0-f68.google.com with SMTP id p63so13047256wmp.1 + for ; Sun, 07 Feb 2016 15:57:21 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:subject:in-reply-to:references:user-agent:date:message-id + :mime-version:content-type; + bh=CsLhQxGE/b/3BS6pyvkJe6vaE7vXnatcLxRrkd5B3mE=; + b=F4JW3B1B6ycCXZVkX3QT56UssEWvTLGnM6KMKI1Hy6SK4001zcqBVqKdGZhBnE3ia1 + yGoF6IbOGYTg3hMNbOMcvPwHh1WsCg+buf7meutWt9W5Srwfl6FJlT6znhH9D3gURIuw + mmZ7HO9qd51eP2A38eQqfq6WFVUDTgGkBkcl0cdoV/MvbPr4SZZQsJatiZwyOd4w4cqu + BhEs/wmcnKJqnvl27ZZ18vOM+RkbicAZsq2ELJf5hThiba/EGUPBZH/hB+yZOMaqTHYH + Yz1k8bOdOMmshmIoyH0mWwoUpyPx3GRjJFRSmQvM0XX7T/Qi96qVcmYRrgCZ/aeD50Az + Jzuw== +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:subject:in-reply-to:references + :user-agent:date:message-id:mime-version:content-type; + bh=CsLhQxGE/b/3BS6pyvkJe6vaE7vXnatcLxRrkd5B3mE=; + b=GjGFB+PHi6l746/E2GO2n1dZHfvPzkMLkNXqP7lY6rJSIEG2ZatnMjk9r/9xVHli0f + ByB3+AzgGloznpV5Q4nV6u0bV48Cdh3qVDlinNxFSsGu0oiR5+CrIfBkZe/kKrlaHz0w + ENg92eMtOOkgPTdrpR/g2YjaRLqn1r8/vldo9ix4si4JIYvA3XkGVz9OrAkcAgKhmobS + qiyDXjOTzKP4aMXE8clm3q8hSixpZAqSGI9JH7kmKf5oTD/Ug4CVpkPJ36ztr6Nj5zax + E4L19gF5mJstLfTyFZ6wWXrVwQzH4nZkg2wJx8Zh/etaVHovmumZeI73mYqRAU3GapIl + 1Pfw== +X-Gm-Message-State: + AG10YOS1+JcFPnapzGrcAfMsXrcT446byfSZ2v5D23uCKVhTZcLQetFVdPK45Fp4QtWgEg== +X-Received: by 10.28.50.137 with SMTP id y131mr50607206wmy.102.1454889440371; + Sun, 07 Feb 2016 15:57:20 -0800 (PST) +Received: from localhost (5751dfa2.skybroadband.com. [87.81.223.162]) + by smtp.gmail.com with ESMTPSA id s8sm27042948wje.35.2016.02.07.15.57.19 + (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Sun, 07 Feb 2016 15:57:19 -0800 (PST) +From: Mark Walters +To: David Edmondson , notmuch@notmuchmail.org +Subject: Re: [PATCH v2 0/2] Allow forwarding of all open messages in the + current view. +In-Reply-To: <1454792877-7180-1-git-send-email-dme@dme.org> +References: <1454792877-7180-1-git-send-email-dme@dme.org> +User-Agent: Notmuch/0.18.1+485~gca076ce (http://notmuchmail.org) Emacs/24.4.1 + (x86_64-pc-linux-gnu) +Date: Sun, 07 Feb 2016 23:57:18 +0000 +Message-ID: <87y4awm5up.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 07 Feb 2016 23:57:24 -0000 + + +On Sat, 06 Feb 2016, David Edmondson wrote: +> Allow forwarding of all open messages in the current view. +> +> In response to id:"87fvyhb40x.fsf@alice.fifthhorseman.net". +> +> v2: +> - Use multiple message forwarding to implement single message +> forwarding. +> + +This basically looks good to me. At the moment there is some typo in the +first patch introducing two extra parenthesis at the end of the +notmuch-mua-new-forward-messages function. + +I checked with both message-forward-as-mime true (default giving rfc822 +parts) and set to nil (including the messages as plain text) and both +looked as I would expect. + +Finally, with this in place it would be very easy to introduce thread +forwarding from search mode. But that can be left until after this. + +Best wishes + +Mark + + +> +> David Edmondson (2): +> emacs: Add `notmuch-show-forward-open-messages'. +> emacs: `notmuch-show-forward-message' can use +> `notmuch-mua-new-forward-messages' +> +> emacs/notmuch-mua.el | 62 +++++++++++++++++++++++++++++++++++++-------------- +> emacs/notmuch-show.el | 15 +++++++++++-- +> 2 files changed, 58 insertions(+), 19 deletions(-) +> +> -- +> 2.1.4 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> https://notmuchmail.org/mailman/listinfo/notmuch